ports/119741: mail/perdition: rc scripts have a mistype in a variable name

[Aleksandr Stankevic]

>Number:         119741
>Category:       ports
>Synopsis:       mail/perdition: rc scripts have a mistype in a variable name
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 17 10:40:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Aleksandr Stankevic
>Release:        7.0 RC1
>Organization:
>Environment:
FreeBSD XXX 7.0-RC1 FreeBSD 7.0-RC1 #1: Wed Jan 16 15:00:23 EET 2008     root at mXXX:/usr/src/sys/amd64/compile/MISS7  amd64

>Description:
mail/perdition has a mistype in rc scripts (perditon_*_flags -> perdition_*_flags). 
This makes the rc scripts not use the ${name}_flags when run on boot, but work fine when run manualy.
On boot, rc.conf is sourced first, and then variable is overwritten by perdition rc script, and when run manually - rc.conf is sources by load_rc_config.
>How-To-Repeat:
cd /usr/ports/mail/perdition && make install
echo 'perdition_pop3_flags="-d"' >> /etc/rc.conf
echo 'perdition_pop3_enable="YES"' >> /etc/rc.conf
reboot

After reboot the daemon will start with default flags (none), and if run manually - with -d.
>Fix:


Patch attached with submission follows:

diff -ruN perdition.orig/Makefile perdition/Makefile
--- perdition.orig/Makefile	2007-12-12 00:15:36.000000000 +0200
+++ perdition/Makefile	2008-01-17 12:10:38.000000000 +0200
@@ -7,7 +7,7 @@
 
 PORTNAME=	perdition
 PORTVERSION=	1.17.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	mail net security
 MASTER_SITES=	http://www.vergenet.net/linux/perdition/download/${PORTVERSION}/
 
diff -ruN perdition.orig/files/perdition.imap4.in perdition/files/perdition.imap4.in
--- perdition.orig/files/perdition.imap4.in	2007-12-12 00:15:36.000000000 +0200
+++ perdition/files/perdition.imap4.in	2008-01-17 12:08:40.000000000 +0200
@@ -14,7 +14,7 @@
 #
 
 perdition_imap4_enable=${perdition_imap4_enable-"NO"}
-perdition_imap4_flags=${perditon_imap4_flags-""}
+perdition_imap4_flags=${perdition_imap4_flags-""}
 
 . %%RC_SUBR%%
 
diff -ruN perdition.orig/files/perdition.imap4s.in perdition/files/perdition.imap4s.in
--- perdition.orig/files/perdition.imap4s.in	2007-12-12 00:15:36.000000000 +0200
+++ perdition/files/perdition.imap4s.in	2008-01-17 12:08:48.000000000 +0200
@@ -14,7 +14,7 @@
 #
 
 perdition_imap4s_enable=${perdition_imap4s_enable-"NO"}
-perdition_imap4s_flags=${perditon_imap4s_flags-""}
+perdition_imap4s_flags=${perdition_imap4s_flags-""}
 
 . %%RC_SUBR%%
 
diff -ruN perdition.orig/files/perdition.imaps.in perdition/files/perdition.imaps.in
--- perdition.orig/files/perdition.imaps.in	2007-12-12 00:15:36.000000000 +0200
+++ perdition/files/perdition.imaps.in	2008-01-17 12:08:58.000000000 +0200
@@ -14,7 +14,7 @@
 #
 
 perdition_imaps_enable=${perdition_imaps_enable-"NO"}
-perdition_imaps_flags=${perditon_imaps_flags-""}
+perdition_imaps_flags=${perdition_imaps_flags-""}
 
 . %%RC_SUBR%%
 
diff -ruN perdition.orig/files/perdition.pop3.in perdition/files/perdition.pop3.in
--- perdition.orig/files/perdition.pop3.in	2007-12-12 00:15:36.000000000 +0200
+++ perdition/files/perdition.pop3.in	2008-01-17 12:09:06.000000000 +0200
@@ -14,7 +14,7 @@
 #
 
 perdition_pop3_enable=${perdition_pop3_enable-"NO"}
-perdition_pop3_flags=${perditon_pop3_flags-""}
+perdition_pop3_flags=${perdition_pop3_flags-""}
 
 . %%RC_SUBR%%
 
diff -ruN perdition.orig/files/perdition.pop3s.in perdition/files/perdition.pop3s.in
--- perdition.orig/files/perdition.pop3s.in	2007-12-12 00:15:36.000000000 +0200
+++ perdition/files/perdition.pop3s.in	2008-01-17 12:09:16.000000000 +0200
@@ -14,7 +14,7 @@
 #
 
 perdition_pop3s_enable=${perdition_pop3s_enable-"NO"}
-perdition_pop3s_flags=${perditon_pop3s_flags-""}
+perdition_pop3s_flags=${perdition_pop3s_flags-""}
 
 . %%RC_SUBR%%
 


>Release-Note:
>Audit-Trail:
>Unformatted: