ports/130064: Patch out superfluous FETCH_CMD that can lock up.

[Julian H. Stacey]

>Number:         130064
>Category:       ports
>Synopsis:       Patch out superfluous FETCH_CMD that can lock up.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 30 22:10:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     "Julian H. Stacey" <jhs at berklix.com>
>Release:        FreeBSD 7.1-RC2 amd64
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
System: FreeBSD fire.js.berklix.net 7.1-RC2 FreeBSD 7.1-RC2 #0: Sat Dec 27 14:42:59 CET 2008 jhs at fire.js.berklix.net:/usr1/src/sys/amd64/compile/FIRE64.small amd64


	
>Description:
	
Default FreeBSD fetch behaviour is better than this port, so
Remove the -ar, else if you get a protocol error, this ports loops for ever
with a simple "make fetch"
>How-To-Repeat:
	
	Break your ftp proxy Or simply have no working ftp, or a broken coms link,
	& specify a local distfiles directory in make.conf,
	then run make fetch & see it loop forever on ftp protocol error.
>Fix:

	
	Apply diff -c patch below


------------------------------------------------
http://berklix.com/~jhs/src/bsd/fixes/freebsd/ports/gen/lang/py-mx-base/Makefile.REL=7.1.diff

Remove the -ar, else if you get a protocol error, this ports loops for ever
with a simple "make fetch", thus it otherwise it prevents a
	"cd /usr/ports ; make -k fetch BATCH=YES"
having any chance of fetching more distfiles - as it loops forever.

Once I removed this damed ar, it passed by my ftp protocol error,
got on to next fetch rule & succeeded, log below:
---------------
ake fetch
===>  Vulnerability check disabled, database not found
=> egenix-mx-base-2.0.6.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch from file:///pub/FreeBSD/dists/current.old//.
fetch: file:///pub/FreeBSD/dists/current.old//egenix-mx-base-2.0.6.tar.gz: No such file or directory
=> Attempting to fetch from /pub/FreeBSD/dists/current.old//.
fetch: /pub/FreeBSD/dists/current.old//egenix-mx-base-2.0.6.tar.gz: No such file or directory
=> Attempting to fetch from ftp://ftp/pub/FreeBSD/dists/current.old//.
fetch: ftp://ftp/pub/FreeBSD/dists/current.old//egenix-mx-base-2.0.6.tar.gz: Not logged in
=> Attempting to fetch from file:///pub/FreeBSD/dists/current//.
egenix-mx-base-2.0.6.tar.gz                   100% of  573 kB 7271 kBps
---------------

Note I have similarly hacked ../../py-mx-experimental/Makefile

*** 7.1/ports/lang/py-mx-base/Makefile.orig	Tue Dec 30 22:06:24 2008
--- generic/ports/lang/py-mx-base/Makefile	Tue Dec 30 22:05:31 2008
***************
*** 16,22 ****
  MAINTAINER=	ports at FreeBSD.org
  COMMENT=	The eGenix mx-Extension Series for Python
  
! FETCH_CMD=	/usr/bin/fetch -ar
  USE_PYTHON=	yes
  USE_PYDISTUTILS=yes
  .if defined(WITH_ZOPE)
--- 16,22 ----
  MAINTAINER=	ports at FreeBSD.org
  COMMENT=	The eGenix mx-Extension Series for Python
  
! # FETCH_CMD=	/usr/bin/fetch -ar
  USE_PYTHON=	yes
  USE_PYDISTUTILS=yes
  .if defined(WITH_ZOPE)
>Release-Note:
>Audit-Trail:
>Unformatted: