ports/129478: patch file to commit to ports

Sun Dec 7 14:10:04 UTC 2008

>Number:         129478
>Category:       ports
>Synopsis:       patch file to commit to ports
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 07 14:10:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     "Julian  H. Stacey" <jhs at berklix.com>
>Release:        FreeBSD 7.1-BETA2 amd64
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
System: FreeBSD fire.js.berklix.net 7.1-BETA2 FreeBSD 7.1-BETA2 #0: Wed Nov 26 14:28:54 CET 2008 jhs at fire.js.berklix.net:/usr1/src/sys/amd64/compile/FIRE64.small amd64

>Description:
	Port fails at run time without this patch.
	Author of generic ports has abandoned maintenance,
	invite to commit to ports
>How-To-Repeat:

	See patch below
>Fix:

Hi acid_kewpie@@@users.sourceforge.net
http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/multimedia/acidrip/files/patch-ja
Patch written by jhs@@@berklix.com 2008.12.05
It is a bug fix, not an enhancement.
It applies to FreeBSD-7.1-BETA2 /usr/ports/multimedia/acidrip
	acidrip-0.14.tar.gz /usr/local/bin/perl5.8.8 
The exact ~/.acidriprc that I used with it is also appended.

The problem was, the log failed at this point:
	mencoder \.\/\/DVDVOLUME1\-1\.vob -alang English -info \
		srcform="DVD ripped by acidrip.sf.net" -oac mp3lame \
		-lameopts abr:br=128 -ovc xvid -xvidencopts :bitrate=4878 \
		-vf pp=de,crop=0:0:0:0,scale=720:-2 -o "./something-1.avi"
	Option xvidencopts: Unknown suboption
	Error parsing option on the command line: -xvidencopts

Hand running the line above after removing the ":" before "bitrate"
worked ok, so I then fixed the Perl script to not prepend ":" before
"bitrate" if xvid_options was null string.

I assume if I had had eg:
	xvid_options = SOMETHING
	it would have chanced to get past the syntax error
but xvid_options was not set by default, & I did not know dummy
values I might set there to satisfy the syntax, & anyway its better
to fix the Perl than set a dummy value.

The still included extra debug is a bit verbose as I am a C programmer,
first venturing into Perl.

*** AcidRip/acidrip.pm.orig	Sat Dec  6 12:35:37 2008
--- AcidRip/acidrip.pm	Sat Dec  6 13:04:18 2008
***************
*** 218,224 ****
      $menc{'video'} .= ":pass=$::settings->{'video_pass'}" if $::settings->{'video_passes'} > 1;
    }
    if ( $::settings->{'video_codec'} eq 'xvid' ) {
!     $menc{'video'} = "-ovc xvid -xvidencopts $::settings->{'xvid_options'}:bitrate=$::settings->{'video_bitrate'}";
      $menc{'video'} .= ":pass=$::settings->{'video_pass'}" if $::settings->{'video_passes'} > 1;
    }
    if ( $::settings->{'video_codec'} eq 'nuv' ) {
--- 218,243 ----
      $menc{'video'} .= ":pass=$::settings->{'video_pass'}" if $::settings->{'video_passes'} > 1;
    }
    if ( $::settings->{'video_codec'} eq 'xvid' ) {
! #----------------
! #ORIGINAL    $menc{'video'} = "-ovc xvid -xvidencopts $::settings->{'xvid_options'}:bitrate=$::settings->{'video_bitrate'}";
!              $menc{'video'} = "-ovc xvid -xvidencopts ";
! 		if ( $::settings->{'xvid_options'} eq '' ) 
! 			{ 
!     			# my $msgaa = "AA You have no xvid_options set.";
!     			# message($msgaa);
!     			# print $msgaa . "\n";
!     			# my $msgbb = "BB You have no xvid_options set.";
!     			# message($msgbb);
!     			# print $msgbb . "\n";
! 			} 
! 		else 
! 			{
!     			# my $msgaa = "AA You do have some xvid_options set.";
!     			# message($msgaa);
!     			# print $msgaa . "\n";
!     			# my $msgbb = "BB You do have some xvid_options set.";
!     			# message($msgbb);
!     			# print $msgbb . "\n";
! 	     		$menc{'video'} .= "$::settings->{'xvid_options'}:" ; 
! 			}
! 	     $menc{'video'} .= "bitrate=$::settings->{'video_bitrate'}";
! #----------------
      $menc{'video'} .= ":pass=$::settings->{'video_pass'}" if $::settings->{'video_passes'} > 1;
    }
    if ( $::settings->{'video_codec'} eq 'nuv' ) {
#------------- ~jhs/.acidriprc
dvd_device = ./
filesize = 1500
filename = ./%T-%N
audio_codec = mp3lame
audio_mp3lame_options = abr:br=128
audio_lavc_options = acodec=mp3:abitrate=128
video_codec = xvid
scale_enable = 1
autoload = 0
mpegfile = 0
eject = 0
scale_auto = 1
scale_height = -2
scale_width = 720
crop_enable = 1
language = English
mencoder = nice mencoder
mplayer = mplayer
lsdvd = lsdvd
tooltips = 1
video_passes = 1
video_bitrate_lock = 0
lavc_options = vcodec=mpeg4:vhq:v4mv:vqmin=2
total_blocks = 1
overwrite = 1
cache = 0
vf_pre_enable = 1
audio_gain = 0
vf_post_enable = 0
vf_pre = pp=de
del_cache = 1
ppc_bug = 0
compact = 0
flickbook_preview = 0
enforce_space = 1
vobsubout = 0
video_bitrate = 0
ui_language = English
-----------------

From: "Chris Phillips" <chris@@@untrepid.com>
Date: Sat, 6 Dec 2008 14:30:26 +0000
To: "Julian Stacey" <jhs@@@berklix.org>

There are alternative views of the following:	(Invoke menu with right button.)

Thanks, unfortunately I'm no longer developing this. feel free to fork, or
just patch within ports.

Cheers

Chris
----------

OK, Thanks Chris,
I'll try to feed it to FreeBSD ports/ for now, I don't think I'm up to being
a fork leader, 'cos this is Perl, & its the 1st Perl I recall hacking :-)

Gary did you retain your ports/ commit bit ?

Julian

>Release-Note:
>Audit-Trail:
>Unformatted: