ports/126441: textproc/isearch fix build with gcc4.2

[Paul Marquis]

The following reply was made to PR ports/126441; it has been noted by GNATS.

From: Paul Marquis <pmarquis at pobox.com>
To: pfgshield-freebsd at yahoo.com
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: ports/126441: textproc/isearch fix build with gcc4.2
Date: Mon, 11 Aug 2008 07:01:43 -0400

 This may fix compilation, but have you tested the resulting program?  I'm 
 concerned about removing the -fwritable-string option, which is described here:
 
 Store string constants in the writable data  segment  and  don't uniquize  them. 
    This  is  for  compatibility with old programs which assume they can write 
 into string constants.  `-traditional' also has this effect.  Writing  into 
 string  constants is a very bad idea; "constants" should be constant.
 
 The original developers must have added this argument for a reason.  I suspect 
 there was some bad runtime behavior that required them to add this argument.
 
 Pedro Giffuni wrote:
 > bah.. a minor fix ... I was including 
 > CFLAGS+= ${CXXFLAGS}
 > which, of course, adds CFLAGS twice.
 > 
 > sorry :(.
 > 
 > 
 > 
 >       Posta, news, sport, oroscopo: tutto in una sola pagina. 
 > Crea l'home page che piace a te!
 > www.yahoo.it/latuapagina
 
 
 -- 
 Paul Marquis
 pmarquis at pobox.com