ports/122590: [PATCH] print/cups-base : fix cups.desktop so a browser really opens

[Michael Johnson]

>Number:         122590
>Category:       ports
>Synopsis:       [PATCH] print/cups-base : fix cups.desktop so a browser really opens
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 09 00:50:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Michael Johnson
>Release:        
>Organization:
>Environment:
>Description:
Add depends on devel/xdg-utils (which has no depends) and use 'xdg-open http://localhost:631/' instead of 'htmlview http://localhost:631' in the cups.desktop file. htmlview is not found in ports... Plus xdg-open works with GNOME, KDE, XFCE, and generic desktops.

I thought about using devel/gvfs for gvfs-open but that would cause a dependency loop, plus I doubt KDE people would like that. =)
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/print/cups-base/Makefile,v
retrieving revision 1.92
diff -u -r1.92 Makefile
--- Makefile	2 Apr 2008 15:20:37 -0000	1.92
+++ Makefile	9 Apr 2008 00:39:24 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	cups
 PORTVERSION=	1.3.7
+PORTREVISION=	1
 DISTVERSIONSUFFIX=	-source
 CATEGORIES=	print
 MASTER_SITES=	EASYSW/${PORTNAME}/${DISTVERSION}
@@ -18,6 +19,7 @@
 LIB_DEPENDS=	jpeg.9:${PORTSDIR}/graphics/jpeg \
 		png.5:${PORTSDIR}/graphics/png \
 		tiff.4:${PORTSDIR}/graphics/tiff
+RUN_DEPENDS=	xdg-open:${PORTSDIR}/devel/xdg-utils
 
 CONFLICTS=	LPRng-[0-9]*
 
@@ -185,6 +187,7 @@
 .endif
 
 post-patch:
+	@${REINPLACE_CMD} -e 's|htmlview|xdg-open|' ${WRKSRC}/desktop/cups.desktop
 	@${REINPLACE_CMD} -e '/SILENT/d' ${WRKSRC}/Makedefs.in
 	@${REINPLACE_CMD} -e '/share/s|/usr/share|${PREFIX}/share|g' ${WRKSRC}/Makefile
 	@${REINPLACE_CMD} -e 's|/etc/cups|/usr/local/etc/cups|g' ${WRKSRC}/man/*.man*


>Release-Note:
>Audit-Trail:
>Unformatted: