ports/111018: graphics/ImageMagick - fail to build when graphics/graphviz is selected

[Scot Hetzel]

>Number:         111018
>Category:       ports
>Synopsis:       graphics/ImageMagick - fail to build when graphics/graphviz is selected
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 29 20:10:04 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Scot Hetzel
>Release:        
>Organization:
>Environment:
>Description:
When IMAGEMAGICK_DOT (GraphViz dot graphs support) is selected the port fails to build, as it is listed a a RUN_DEPENDS when it should be a LIB_DEPENDS.

/bin/sh /usr/local/bin/libtool --silent --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I./magick -I./wand  -I./ltdl -I./ltdl  -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include -I/usr/X11R6/include -I/usr/local/include/libxml2  -O -pipe  -MT coders/magick_libMagick_la-dot.lo -MD -MP -MF coders/.deps/magick_libMagick_la-dot.Tpo -c -o coders/magick_libMagick_la-dot.lo `test -f 'coders/dot.c' || echo './'`coders/dot.c
coders/dot.c:64:17: gvc.h: No such file or directory
coders/dot.c:66: error: syntax error before '*' token
coders/dot.c:66: warning: data definition has no type or storage class
coders/dot.c: In function `ReadDOTImage':
coders/dot.c:106: error: `graph_t' undeclared (first use in this function)
coders/dot.c:106: error: (Each undeclared identifier is reported only once
coders/dot.c:106: error: for each function it appears in.)
coders/dot.c:106: error: `graph' undeclared (first use in this function)
coders/dot.c:137: error: syntax error before ')' token
coders/dot.c: In function `RegisterDOTImage':
coders/dot.c:195: warning: assignment makes pointer from integer without a cast
gmake: *** [coders/magick_libMagick_la-dot.lo] Error 1
*** Error code 2

Stop in /usr/ports/graphics/ImageMagick.

>How-To-Repeat:
cd /usr/ports/graphics/ImageMagick
make build

- Select 'GraphViz dot graphs support' from the config menu.


>Fix:
Apply the attached patch.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/graphics/ImageMagick/Makefile,v
retrieving revision 1.233
diff -u -r1.233 Makefile
--- Makefile	16 Mar 2007 20:23:59 -0000	1.233
+++ Makefile	17 Mar 2007 16:14:50 -0000
@@ -181,8 +181,8 @@
 
 # GraphViz dot graphs
 .if defined(WITH_IMAGEMAGICK_DOT)
-BUILD_DEPENDS+=		dot:${PORTSDIR}/graphics/graphviz
-RUN_DEPENDS+=		dot:${PORTSDIR}/graphics/graphviz
+LIB_DEPENDS+=		gvc.3:${PORTSDIR}/graphics/graphviz
+LDFLAGS+=		-L${LOCALBASE}/lib/graphviz
 .else
 CONFIGURE_ARGS+=	--without-dot --without-gvc
 .endif

>Release-Note:
>Audit-Trail:
>Unformatted: