ports/115455: [PATCH] ports-mgmt/portlint: add check for --(man|info)dir

[Rong-En Fan]

>Number:         115455
>Category:       ports
>Synopsis:       [PATCH] ports-mgmt/portlint: add check for --(man|info)dir
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 13 07:50:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Rong-En Fan
>Release:        FreeBSD 6.2-STABLE amd64
>Organization:
NTU CSIE
>Environment:
>Description:
As I add --mandir and --infodir for GNU_CONFIGURE last month, here
is a patch for portlint to issue warning about a port that sets
them manually. I dont set it as error because in rare cases, a port
may need this (likes games/volleyball).

Port maintainer (marcus at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- portlint-2.9.4.patch begins here ---
Index: src/portlint.pl
===================================================================
RCS file: /big/freebsd-cvsup/ncvs/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.94
diff -u -u -r1.94 portlint.pl
--- src/portlint.pl	9 Jun 2007 19:02:10 -0000	1.94
+++ src/portlint.pl	13 Aug 2007 07:45:33 -0000
@@ -187,6 +187,7 @@
 	INDEXFILE PKGORIGIN CONFLICTS PKG_VERSION PKGINSTALLVER
 	PLIST_FILES OPTIONS INSTALLS_OMF USE_GETTEXT USE_RC_SUBR
 	DIST_SUBDIR ALLFILES IGNOREFILES CHECKSUM_ALGORITHMS INSTALLS_ICONS
+	GNU_CONFIGURE CONFIGURE_ARGS
 );
 
 my $cmd = join(' -V ', "make $makeenv MASTER_SITE_BACKUP=''", @varlist);
@@ -1660,6 +1661,15 @@
 	}
 
 	#
+	# whole file: check for --mandir and --infodir when GNU_CONFIGURE
+	#
+	if ($makevar{GNU_CONFIGURE} ne '' &&
+		$makevar{CONFIGURE_ARGS} =~ /(man|info)dir/) {
+		&perror("WARN", $file, -1, "--mandir and --infodir in CONFIGURE_ARGS ".
+			"are not needed.  They are set in bsd.port.mk");
+	}
+
+	#
 	# slave port check
 	#
 	my $masterdir = $makevar{MASTERDIR};
--- portlint-2.9.4.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: