ports/111731: milter-dkim.sh supplies -k option to a verifying-only milter

[Mark Martinec]

>Number:         111731
>Category:       ports
>Synopsis:       milter-dkim.sh supplies -k option to a verifying-only milter
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 16 19:20:12 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Mark Martinec
>Release:        6.2-RELEASE-p1
>Organization:
Jozef Stefan Institute
>Environment:
FreeBSD xxx.ijs.si 6.2-RELEASE-p1 FreeBSD 6.2-RELEASE-p1 #0: Sun Feb 25 04:16:09 CET 2007     xxx at xxx.ijs.si:/usr/obj/usr/src/sys/XXX  i386
>Description:
A recent change to a mail/dkim-milter startup script started to supply
a gratuitous options '-k /var/db/domainkeys/default.key.pem -s default'
even when starting a milter in a verification-only mode '-b v',
thus breaking existing installations and requiring a workaround.

Since the /var/db/domainkeys/default.key.pem does not exist (and need
not exist), the milter refuses to start (here is a clip from a startup
with shell echo enabled):

+ /usr/local/libexec/dkim-filter -b v -l -p inet:4443 at 127.0.0.1
  -u dkimfilter -P /var/run/milterdkim/verifier.pid -d ijs.si
  -k /var/db/domainkeys/default.key.pem -s default
dkim-filter: /var/db/domainkeys/default.key.pem:
  stat(): No such file or directory

A section from my /etc/rc.conf, pertaining to "verifier":

milterdkim_enable="YES"
milterdkim_uid='dkimfilter'
milterdkim_domain='ijs.si'
milterdkim_profiles="verifier signer"
milterdkim_verifier_socket='inet:4443 at 127.0.0.1'
milterdkim_verifier_flags='-b v'

>How-To-Repeat:
Place the following in /etc/rc.conf:

milterdkim_enable="YES"
milterdkim_uid='dkimfilter'
milterdkim_domain='example.com'
milterdkim_socket='inet:4443 at 127.0.0.1'
milterdkim_flags='-b v'

and start the milter:

# /usr/local/etc/rc.d/milter-dkim start
Starting milterdkim.
dkim-filter: /var/db/domainkeys/default.key.pem: stat(): No such file or directory

>Fix:
A workaround it to supply a dummy key file (which won't be used)
to a verifying-only milter.
>Release-Note:
>Audit-Trail:
>Unformatted: