ports/111151: ports/lang/stklos: l/bin/stklos-install is a buggy shell script

[clemens fischer]

>Number:         111151
>Category:       ports
>Synopsis:       ports/lang/stklos: l/bin/stklos-install is a buggy shell script
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 02 19:50:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     clemens fischer
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:

System: FreeBSD spotteswoode.dnsalias.org 6.2-STABLE
FreeBSD 6.2-STABLE #16: Mon Mar 5 16:49:13 CET 2007
root at spotteswoode.dnsalias.org:/usr/obj/usr/src/sys/spott i386

>Description:

it's impossible to install stklos "extensions" due to errors in script:
local/bin/stklos-install.

what i didn't understand is the absence of
local/lib/stklos/0.82/syslog.{so,stk}, which seem to be important for
installing the "htmlprag" extension.

this lib directory just contains: local/lib/stklos/0.82/ldap.so, which
i don't even need.

>How-To-Repeat:

you could try "stklos-install htmlprag" and watch it fail.  this command
downloads an extension, configures, makes and installs it.

  /tmp/stklos-setup-6509/htmlprag-0.50
  1  # stklos-install -k htmlprag
  **** Installing package htmlprag
  **** Installation takes place in in /tmp/stklos-setup-7573/htmlprag
  x htmlprag-0.50/
  x htmlprag-0.50/.hgtags
  x htmlprag-0.50/COPYING
  x htmlprag-0.50/ChangeLog
  x htmlprag-0.50/Makefile.in
  x htmlprag-0.50/README
  x htmlprag-0.50/adapt.stk
  x htmlprag-0.50/configure
  x htmlprag-0.50/configure.in
  x htmlprag-0.50/doc/
  x htmlprag-0.50/doc/Makefile.in
  x htmlprag-0.50/doc/eg-web-extension.ske
  x htmlprag-0.50/doc/htmlprag-doc-style.css
  x htmlprag-0.50/doc/htmlprag-doc-style.tex
  x htmlprag-0.50/doc/htmlprag-original.html
  x htmlprag-0.50/doc/htmlprag.html
  x htmlprag-0.50/doc/htmlprag.pdf
  x htmlprag-0.50/doc/htmlprag.skb
  x htmlprag-0.50/doc/lib.stk
  x htmlprag-0.50/doc/version.stk.in
  x htmlprag-0.50/examples/
  x htmlprag-0.50/examples/Makefile.in
  x htmlprag-0.50/examples/testhtmlprag.stk
  x htmlprag-0.50/htmlprag.scm
  x htmlprag-0.50/htmlprag.stk
  **** Configuring package ...
  configure: creating ./config.status
  config.status: creating Makefile
  config.status: creating doc/Makefile
  config.status: creating doc/version.stk
  config.status: creating examples/Makefile
  **** Make package ...
  stklos -f adapt htmlprag.scm htmlprag.ss
  ** define-syntax %htmlprag:testeez skipped
  ** define %htmlprag:a2c skipped
  ** define (%htmlprag:append! a b) skipped
  ** define %htmlprag:reverse!ok skipped
  ** define-syntax %htmlprag:error skipped
  ** define (%htmlprag:down s) skipped
  ** define %htmlprag:down!ok skipped
  ** define (%htmlprag:gosc os) skipped
  ** define (%htmlprag:test) skipped
  ** EOF
  stklos-compile -o htmlprag.ostk htmlprag.stk
  Compilation time 406.25
  (cd examples; gmake)
  gmake[1]: Entering directory `/tmp/stklos-setup-7573/htmlprag-0.50/examples'
  stklos-compile -o testhtmlprag testhtmlprag.stk
  testhtmlprag.stk:34: warning: reference to undefined symbol html->sxml-2nf
  Compilation time 7.8125
  gmake[1]: Leaving directory `/tmp/stklos-setup-7573/htmlprag-0.50/examples'
  **** Installing package ...
  (cd examples; gmake)
  gmake[1]: Entering directory `/tmp/stklos-setup-7573/htmlprag-0.50/examples'
  gmake[1]: Nothing to be done for `all'.
  gmake[1]: Leaving directory `/tmp/stklos-setup-7573/htmlprag-0.50/examples'
  (cd doc; make install)
  (cd  ..;  for i in htmlprag.html htmlprag-doc-style.css ; do  stklos-ext-install htmlprag-0.50 doc/$i share/stklos/`stklos-config -v`  0644 ;  done)
  (cd examples; make install)
  stklos-ext-install htmlprag-0.50 syslog.so lib/stklos/`stklos-config -v` 0755
  cp: syslog.so: No such file or directory
  chmod: /usr/local/lib/stklos/0.82/syslog.so: No such file or directory
  stklos-ext-install htmlprag-0.50 syslog.stk lib/stklos/`stklos-config -v` 0755
  cp: syslog.stk: No such file or directory
  chmod: /usr/local/lib/stklos/0.82/syslog.stk: No such file or directory
  **** Problem while compiling package.
  **** Look at /tmp/stklos-setup-7573/htmlprag directory for more information
  **** Package htmlprag is successfully installed.

  /tmp/stklos-setup-6509/htmlprag-0.50
  0  # stklos-install -l
  **** Available extensions:
          htmlprag-0.50

>Fix:

/l/bin/stklos-install implies having the current directory in $PATH, and
the Makefile is built using autoconf and wants gmake instead of make:

rcsdiff --unified /l/bin/stklos-install /RCS/STKLOS/stklos-install,v
===================================================================
RCS file: /RCS/STKLOS/stklos-install,v
retrieving revision 1.2
diff --unified -r1.2 /l/bin/stklos-install
--- /l/bin/stklos-install       2007/04/02 17:16:17     1.2
+++ /l/bin/stklos-install       2007/04/02 17:18:24
@@ -128,9 +128,9 @@
     cat $pkg.stgz | (cd $TMP; tar xvfz -)

     (eval "cd ${BUILDDIR}*";
-     trace "Configuring package ..." && configure &&
-     trace "Make package ..." &&  make &&
-     trace "Installing package ..." && make install)
+     trace "Configuring package ..." && ./configure &&
+     trace "Make package ..." &&  gmake &&
+     trace "Installing package ..." && gmake install)

     if [ $? = 0 -a $opt_keep = 0 ] ;then
        /bin/rm -rf $TMP
>Release-Note:
>Audit-Trail:
>Unformatted: