ports/97327: [MAINTAINER] mail/exilog: fix rc.d stuff

Larry Rosenman ler at lerctr.org
Tue May 16 02:50:17 UTC 2006


The following reply was made to PR ports/97327; it has been noted by GNATS.

From: "Larry Rosenman" <ler at lerctr.org>
To: "'Ion-Mihai IOnut Tetcu'" <itetcu at FreeBSD.org>
Cc: <FreeBSD-gnats-submit at FreeBSD.org>
Subject: RE: ports/97327: [MAINTAINER] mail/exilog: fix rc.d stuff
Date: Mon, 15 May 2006 21:48:38 -0500

 Ion-Mihai IOnut Tetcu wrote:
 > On Mon, 15 May 2006 18:41:57 -0500
 > Larry Rosenman <ler at lerctr.org> wrote:
 > 
 >>  USE_RC_SUBR=	exilog.sh
 > 
 >>  PLIST_SUB+=	AGENT=""
 >> +.if (${OSVERSION} >= 700007 || (${OSVERSION} < 700000 &&
 >> ${OSVERSION} +>= 600101)) +  RCSCRIPT=exilog
 >> +.else
 >> +  RCSCRIPT=exilog.sh
 >> +.endif
 >> +PLIST_SUB+=	RCSCRIPT=${RCSCRIPT}
 >>  .endif
 > 
 > This is not needed, USE_RC_SUBR takes care of it and installs one
 > rc.d script, depending of OSVERSION. 
 
 I was trying to get the system to stop the daemon on uninstall, and
 therefore need 
 To know which flavor (see my question and Pav's response on -ports earlier).
 
 
 
 > 
 >> 
 >>  PLIST_SUB+=	EXILOGDIR="${EXILOGDIR:S,^${PREFIX}/,,}" @@ -76,9 +84,6
 >>  	@@ @${CHMOD} 0600 ${PREFIX}/etc/exilog.conf-dist
 >>  	@${CHOWN} ${WWWOWN}:${WWWGRP} ${PREFIX}/etc/exilog.conf-dist
 >>  	@${CP} ${FILESDIR}/htaccess ${EXILOGDIR}/.htaccess -.if
 >> !defined(NO_AGENT) 
 >> -	@${INSTALL_SCRIPT} ${WRKDIR}/exilog.sh ${PREFIX}/etc/rc.d
 >> -.endif
 > 
 > Personally I disagree with this behavior, if the server doesn't crash
 > w/o the deleted files (think of portupgrade'ing), YMMV. 
 The old Makefile installed the exilog.sh unconditionally, I was removing it
 so 
 That USE_RC_SUBR would handle it. 
 > 
 >> +%%AGENT%%etc/rc.d/%%RCSCRIPT%%
 
 Ok, I can kill this one. 
 
 > 
 > This is not need either. USE_RC_SUBR takes care of it.
 > 
 > I would also change NO_AGENT --> WITH[OUT]_AGENT Current Makefile
 > lacks some "()":  .ifndef WITHOUT_WWWDIR Also it could use OPTIONS. 
 
 I did this in the above diff.
 
 
 
 
 -- 
 Larry Rosenman                     http://www.lerctr.org/~ler
 Phone: +1 512-248-2683                 E-Mail: ler at lerctr.org
 US Mail: 430 Valona Loop, Round Rock, TX 78681-3683 US
 



More information about the freebsd-ports-bugs mailing list