ports/94378: piewm: (malloc) Corrupted redzone 1 byte after 0xa00cbe0 (size 41) (0x0)

[David Wolfskill]

The following reply was made to PR ports/94378; it has been noted by GNATS.

From: David Wolfskill <david at catwhisker.org>
To: bug-followup at freebsd.org
Cc:  
Subject: ports/94378: piewm: (malloc) Corrupted redzone 1 byte after 0xa00cbe0 (size 41) (0x0)
Date: Tue, 14 Mar 2006 09:34:58 -0800

 Looks as if there should be an updated source tarball soon, if not
 already.
 
 ----- Forwarded message from Russell Nelson <nelson at crynwr.com> -----
 
 From: Russell Nelson <nelson at crynwr.com>
 Date: Tue, 14 Mar 2006 10:58:53 -0500
 To: David Wolfskill <david at catwhisker.org>
 Subject: Re: Off-by-one bug in piewm -- interested?
 
 Thanks!  Fixed.
 -russ
 
 David Wolfskill writes:
  > 
  > I filed a PR with the FreeBSD ports folks Saturday (11 March), but the
  > bug appears to be in tghe sources for piewm itself (rather than the
  > "port" gunk thatt FreeBSD uses to build 3rd-party applications), and a
  > colleague at work -- who also uses piewm -- mentioned that you might
  > have an interest in the fix.
  > 
  > Since the PR includes the (nearly trivial) fix, I'll direct you to
  > <http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/94378> for the
  > explanation & unidiff-formatted patch.
  > 
  > Succinctly, the #define for EXTRA in parse.c needs to be (at least) 12,
  > rather than 11 -- it's an off-by-one error in calculating how much
  > memory will be needed for creating a line of m4 input.
  > 
  > Turns out that tvtwm doesn't have the problem:  although tvtwm also
  > spits out the "dnl" token (which was intentionally omitted for piewm),
  > tvtwm's EXTRA is 15.  Looks as if someone got a touch over-zealous with
  > respect to trying to ensure that piewm didn't allocate more memory than
  > necessary.
  > 
  > Peace,
  > david
  > -- 
  > David H. Wolfskill				david at catwhisker.org
  > Mail filters, like sewers, need to be most restrictive at the point of entry.
  > 
  > See http://www.catwhisker.org/~david/publickey.gpg for my public key.
 
 ----- End forwarded message -----
 
 Peace,
 david
 -- 
 David H. Wolfskill				david at catwhisker.org
 Mail filters, like sewers, need to be most restrictive at the point of entry.
 
 See http://www.catwhisker.org/~david/publickey.gpg for my public key.