ports/94300: [NEW PORT]: net-im/sim-im-devel: Plugin-based instant messenger

[Ion-Mihai Tetcu]

The following reply was made to PR ports/94300; it has been noted by GNATS.

From: Ion-Mihai Tetcu <itetcu at people.tecnik93.com>
To: "Alexey V. Panfilov" <sim-im at lehis.ru>
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: ports/94300: [NEW PORT]: net-im/sim-im-devel: Plugin-based
 instant messenger
Date: Sat, 11 Mar 2006 04:12:31 +0200

 On Fri, 10 Mar 2006 17:15:10 +0300 (MSK)
 "Alexey V. Panfilov" <sim-im at lehis.ru> wrote:
 
 > 
 > >Number:         94300
 > >Category:       ports
 > >Synopsis:       [NEW PORT]: net-im/sim-im-devel: Plugin-based instant messenger
 
  [ ... ]
 
 Thanks for your work.
 
 > sed 's/^X//' >sim-im-devel/Makefile << 'END-of-sim-im-devel/Makefile'
 > X# New Ports Collection Makefile for:	sim-im-devel
 > X# Date created:				3 Mar 2006
 > X# Whom:					Alexey V. Panfilov <sim-im at lehis.ru>
 > X#
 > X# $FreeBSD$
 > X
 > XPORTNAME=	sim-im-devel
 > XPORTVERSION=	0.9.5.377
 > XPORTREVISION=	1
 
 Why do you set PORTREVISION for a new port ?
 
 > XCATEGORIES=	net-im kde
 
 You're defaulting KDE to off, so kde shouldn't be in CATEGORIES.
 
 > XMASTER_SITES=	http://sim-im.lehis.ru/dist/
 > X
 > XMAINTAINER=	sim-im at lehis.ru
 > XCOMMENT=	Plugin-based instant messenger
 > X
 > XLIB_DEPENDS=	xslt.2:${PORTSDIR}/textproc/libxslt
 > X
 > XUSE_BZIP2=      yes
 > XUSE_GMAKE=	yes
 > XUSE_QT_VER=	3
 > XUSE_PERL5_BUILD=	yes
 > XGNU_CONFIGURE=	yes
 > XREINPLACE_CMD=	yes
 
 This is wrong. You probably thought about USE_REINPLEACE= yes, which is
 not needed anymore; more, you don't use this anywhere.
 
  [ ... ]
 
 > XPORT_DBDIR?=	/var/db/ports
 > XLATEST_LINK=	${PORTNAME}${PKGNAMESUFFIX}
 > XOPTIONSFILE?=	${PORT_DBDIR}/${LATEST_LINK}/options
 > X
 > X.if exists(${OPTIONSFILE})
 > X.include "${OPTIONSFILE}"
 > X.endif
 
 Do you really need this block ? Is there any reason you can't use 
 ..include <bsd.port.pre.mk> after OPTIONS= ... and before checking 
 WITH* and .include <bsd.port.post.mk>  at the end of the file instead
 of .include <bsd.port.mk> ?
 
 > X.if defined(WITH_DEB)
 
 There is a standard knob for debug called DEBUG (please
 see /usr/ports/KNOBS).
 
 > XCONFIGURE_ARGS+=--enable-debug
 > X.endif
 > X.if defined(WITH_SSL)
 > XUSE_OPENSSL=	yes
 > XPLIST_SUB+=	SSL=""
 > X.else
 > XCONFIGURE_ARGS+=--disable-openssl
 > XPLIST_SUB+=	SSL="@comment "
 > X.endif
 > X.if !defined(WITH_KDE)
 > XCONFIGURE_ARGS+=--disable-kde --enable-mt
 > XLIB_DEPENDS+=	aspell.16:${PORTSDIR}/textproc/aspell
 > XPLIST_SUB+=	KDE="@comment " \
 > X		SPELL=""
 > X.else
 > XUSE_KDELIBS_VER=3
 > XPLIST_SUB+=	KDE="" \
 > X		SPELL="@comment "
 > X.endif
 > X
 > Xpre-everything::
 > X.if defined(WITH_SSL)
 > X	@${ECHO_MSG} "You can disable SSL support by defining WITHOUT_SSL."
 > X.endif
 > X.if defined(WITH_KDE)
 > X	@${ECHO_MSG} "You can disable KDE support by defining WITHOUT_KDE."
 > X.endif
 
 These two echo are redundant with the OPTIONS screen, no ?
 
 
 Please run portlint(1) before submitting a new port or an update.
 
 Thanks again for your work on porting this.
 
 -- 
 IOnut - Unregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 
 There is a multi-legged creature crawling on your shoulder.
 		-- Spock, "A Taste of Armageddon", stardate 3193.9