ports/99285: mutt-devel port WITH_NCURSES_PORT doesn't use ncurses port

[Tim Smith]

>Number:         99285
>Category:       ports
>Synopsis:       mutt-devel port WITH_NCURSES_PORT doesn't use ncurses port
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 22 00:20:20 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Tim Smith
>Release:        RELENG_6
>Organization:
>Environment:
FreeBSD siva.hindu.god 6.1-STABLE FreeBSD 6.1-STABLE #0: Sun Jun 18 13:23:52 MDT 2006     root at siva.hindu.god:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
It's useful to compile mutt with the ncurses port, to get proper support for wide characters (UTF-8 in particular).

The mail/mutt port does this correctly; the mail/mutt-devel port does not.

>How-To-Repeat:
Add this to /etc/make.conf:

.if ${.CURDIR:M*/mail/mutt-devel*}
WITH_MUTT_NCURSES_PORT=YES
.endif

Then:

cd /usr/ports/mail/mutt-devel
make

Notice the configure output:

checking for waddnwstr in -lncurses... no
checking for waddnwstr in -lncursesw... no

And 'ldd mutt' shows:
        libncurses.so.6 => /lib/libncurses.so.6 (0x28102000)

Finally, to test, run mutt with LC_ALL=en_US.UTF-8 (or similar), and examine the results.  Multi-byte chars won't display correctly, and formatting will be wrong.

After the patch (see "Fix" section):

checking for waddnwstr in -lncurses... no
checking for waddnwstr in -lncursesw... yes

And:

        libncursesw.so => /usr/local/lib/libncursesw.so (0x280f9000)

The final proof is that running mutt displays all characters correctly, with no formating problems.

>Fix:
--- Makefile.orig       Wed Jun 21 17:32:48 2006
+++ Makefile    Wed Jun 21 18:03:17 2006
@@ -279,7 +279,7 @@
 .if defined(NOPORTDOCS)
 XML_USED=      no
 .endif
-.if defined(MUTT_USES_NCURSES) && ${OSVERSION} < 400000
+.if defined(WITH_MUTT_NCURSES_PORT) || defined(MUTT_USES_NCURSES) && ${OSVERSION} < 400000
 LIB_DEPENDS+=  ncurses.5:${PORTSDIR}/devel/ncurses
 CFLAGS+=       -I${LOCALBASE}/include/ncurses -I${LOCALBASE}/include
 .elif defined(MUTT_USES_SLANG1)
@@ -348,7 +348,7 @@
 .if defined(WITH_MUTT_LOCALES_FIX)
 CONFIGURE_ARGS+=       --enable-locales-fix
 .endif
-.if defined(MUTT_USES_NCURSES) && ${OSVERSION} < 400000
+.if defined(WITH_MUTT_NCURSES_PORT) || defined(MUTT_USES_NCURSES) && ${OSVERSION} < 400000
 CONFIGURE_ARGS+=       --with-curses=${LOCALBASE}
 .elif defined(MUTT_USES_SLANG)
 CONFIGURE_ARGS+=       --with-slang=${LOCALBASE}

>Release-Note:
>Audit-Trail:
>Unformatted: