ports/99202: Unbreak port: math/vtk*

[TAOKA Fumiyoshi]

>Number:         99202
>Category:       ports
>Synopsis:       Unbreak port: math/vtk*
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 20 12:30:19 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     TAOKA Fumiyoshi
>Release:        
>Organization:
>Environment:
>Description:

Vtk wrapper slave ports, math/vtk-{java,python,tcl} fail to build
at INSTALL_TARGETS in {Common,Filtering,Graphics,Hybrid,IO,Imaging,
Rendering,Patented,Parallel}/CMakeLists.txt.

>How-To-Repeat:
	
For example, in math/vtk-python:

# make
===>  Extracting for vtk-python-4.4_1
=> MD5 Checksum OK for VTK-4.4-LatestRelease.tar.gz.
=> SHA256 Checksum OK for VTK-4.4-LatestRelease.tar.gz.
===>  Patching for vtk-python-4.4_1
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/Common/CMakeLists.txt ...
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/Filtering/CMakeLists.txt ...
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/Graphics/CMakeLists.txt ...
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/Hybrid/CMakeLists.txt ...
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/IO/CMakeLists.txt ...
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/Imaging/CMakeLists.txt ...
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/Rendering/CMakeLists.txt ...
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/Parallel/CMakeLists.txt ...
Patching /usr/ports/math/vtk-python/work//usr/ports/math/vtk-python/work/VTK/Patented/CMakeLists.txt ...

(snip)

CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/Common/CMakeLists.txt:335:
INSTALL_TARGETS Cannot find target: "vtkCommon" to install.
CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/Filtering/CMakeLists.txt:196:
INSTALL_TARGETS Cannot find target: "vtkFiltering" to install.
CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/Imaging/CMakeLists.txt:205:
INSTALL_TARGETS Cannot find target: "vtkImaging" to install.
CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/Graphics/CMakeLists.txt:256:
INSTALL_TARGETS Cannot find target: "vtkGraphics" to install.
CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/IO/CMakeLists.txt:235:
INSTALL_TARGETS Cannot find target: "vtkIO" to install.
CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/Rendering/CMakeLists.txt:415:
INSTALL_TARGETS Cannot find target: "vtkRendering" to install.
CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/Hybrid/CMakeLists.txt:162:
INSTALL_TARGETS Cannot find target: "vtkHybrid" to install.
CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/Patented/CMakeLists.txt:108:
INSTALL_TARGETS Cannot find target: "vtkPatented" to install.
CMake Error: Error in cmake code at
/usr/ports/math/vtk-python/work/VTK/Parallel/CMakeLists.txt:185:
INSTALL_TARGETS Cannot find target: "vtkParallel" to install.
-- Configuring done
*** Error code 255

Stop in /usr/ports/math/vtk-python.

>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/math/vtk/Makefile,v
retrieving revision 1.34
diff -u -r1.34 Makefile
--- Makefile	10 May 2006 22:37:14 -0000	1.34
+++ Makefile	20 Jun 2006 07:31:46 -0000
@@ -23,8 +23,6 @@
 MAINTAINER=	ko at irfu.se
 COMMENT?=	The Visualization Toolkit shared libs
 
-BROKEN=		Does not build
-
 LIBVER=		1
 VTKSRCDIR=	${WRKDIR}/VTK
 TESTINGDIR=	${EXAMPLESDIR}/Testing
@@ -155,6 +153,8 @@
 #
 #       -TARGET_LINK_LIBRARIES(vtk${KIT} ${KIT_LIBS})
 #
+#       -INSTALL_TARGETS(/lib/vtk vtk${KIT})
+#
 # ${VTKSRCDIR}/[Common Filtering IO ...]/Tests/CMakeLists.txt :
 #       -SUBDIRS(Cxx)
 #
@@ -163,7 +163,7 @@
 
 	@for dir in ${VTK_KITS} ; do \
 		${ECHO_MSG} "Patching ${WRKDIR}/${VTKSRCDIR}/$$dir/CMakeLists.txt ..." ; \
-		${REINPLACE_CMD} -E 's|ADD_LIBRARY *\(vtk\$$\{KIT\} .*$$|FIND_LIBRARY\('$$dir'_LIB NAMES vtk\$$\{KIT\} PATHS ${PREFIX}/lib\)|g ; s|TARGET_LINK_LIBRARIES *\(vtk\$$\{KIT\}${WRAP} vtk\$$\{KIT\}|TARGET_LINK_LIBRARIES\(vtk\$$\{KIT\}${WRAP} \$$\{'$$dir'_LIB\}|g ; s|^[ \t]*vtk\$$\{KIT\}[ \t]*$$| \$$\{'$$dir'_LIB\}|g ; s|TARGET_LINK_LIBRARIES *\(vtk\$$\{KIT\} .*$$||g' \
+		${REINPLACE_CMD} -E 's|ADD_LIBRARY *\(vtk\$$\{KIT\} .*$$|FIND_LIBRARY\('$$dir'_LIB NAMES vtk\$$\{KIT\} PATHS ${PREFIX}/lib\)|g ; s|TARGET_LINK_LIBRARIES *\(vtk\$$\{KIT\}${WRAP} vtk\$$\{KIT\}|TARGET_LINK_LIBRARIES\(vtk\$$\{KIT\}${WRAP} \$$\{'$$dir'_LIB\}|g ; s|^[ \t]*vtk\$$\{KIT\}[ \t]*$$| \$$\{'$$dir'_LIB\}|g ; s|TARGET_LINK_LIBRARIES *\(vtk\$$\{KIT\} .*$$||g ; s|INSTALL_TARGETS *\(.* vtk\$$\{KIT\}\)||g' \
 			${VTKSRCDIR}/$$dir/CMakeLists.txt ; \
 	done

>Release-Note:
>Audit-Trail:
>Unformatted: