ports/92414: [patch] net/vnc Xvnc server doesn't run with XDMCP options

[Akihiro KAYAMA]

>Number:         92414
>Category:       ports
>Synopsis:       [patch] net/vnc Xvnc server doesn't run with XDMCP options
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 27 09:50:01 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Akihiro KAYAMA
>Release:        FreeBSD 6.0-RELEASE-p2
>Organization:
PERSONAL-MEDIA Corp.
>Environment:
FreeBSD net2.personal-media.co.jp 6.0-RELEASE-p2 FreeBSD 6.0-RELEASE-p2 #0: Thu Jan 19 19:45:59 JST 2006     kayama at pc137.personal-media.co.jp:/usr/obj/home/src/sys/GENERIC  i386
vnc-4.1.1
xorg-clients-6.8.2
xorg-server-6.9.0

>Description:
Xvnc, which is modified X server to draw desktop remotely with vnc
protocol, can be managed with X Display Manager via XDMCP when
combined with option -query. 

But FreeBSD port version of Xvnc seemed to fail to create a session
with xdm, due to xdm error "Decline No valid address".

>How-To-Repeat:
execute xdm:
% /usr/X11R6/bin/xdm -debug 1

execute Xvnc server:
% /usr/local/bin/Xvnc :59 -query localhost -once  securitytypes=none Log='*:stderr:9'

Xvnc fails to start and outputs following error messages:
Fatal server error:
XDMCP fatal error: Session declined No valid address

>Fix:
This is because of an uninitialized variable bug of XFree 4.3.0 source
tree which current vnc port use. Simply apply the following patch, or
perhaps it is better choice to use fixed X source tree like X.org
6.9.0.

--- xc/programs/Xserver/os/access.c.orig	Fri Jan 27 16:23:17 2006
+++ xc/programs/Xserver/os/access.c	Fri Jan 27 16:22:32 2006
@@ -730,6 +730,7 @@
 	if (ifr->ifa_addr.sa_family == AF_DECnet) 
 	    continue;
 #endif /* DNETCONN */
+	len = sizeof(*(ifr->ifa_addr));
 	family = ConvertAddr(ifr->ifa_addr, &len, (pointer *)&addr);
 	if (family == -1 || family == FamilyLocal) 
 	    continue;

>Release-Note:
>Audit-Trail:
>Unformatted: