ports/92322: bsd.port.mk: Bug in LDCONFIG_CMD in the linux case

[Alexander Leidinger]

>Number:         92322
>Category:       ports
>Synopsis:       bsd.port.mk: Bug in LDCONFIG_CMD in the linux case
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 25 18:50:02 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Alexander Leidinger
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
FreeBSD 
>Environment:


System: FreeBSD 7.0-CURRENT #180: Sun Jan 22 16:26:36 CET 2006
    root at Magellan.Leidinger.net:/big/usr/src/sys/i386/compile/WORK



>Description:


The linux ldconfig invocation has to be done in a chroot, else some FreeBSD native libs get cached in the linux ld.so.cache. The linux ldconfig contains chroot code, so no need to call chroot(8).

The attached patch makes use of the internal chroot feature of the linux ldconfig. Since this feature was just introduced in the last commit of bsd.port.mk, and since it only affects the linux side (in a bad way if used), does this need a full run on the cluster, or is it ok if I commit it "now"?


>How-To-Repeat:





>Fix:


--- bsd.port.mk.diff begins here ---
Index: Mk/bsd.port.mk
===================================================================
RCS file: /big/FreeBSD-CVS/ports/Mk/bsd.port.mk,v
retrieving revision 1.523
diff -u -u -r1.523 bsd.port.mk
--- Mk/bsd.port.mk	23 Jan 2006 22:29:26 -0000	1.523
+++ Mk/bsd.port.mk	25 Jan 2006 18:31:31 -0000
@@ -1274,7 +1274,7 @@
 .endif
 
 .if defined(USE_LINUX_PREFIX)
-LDCONFIG_CMD?=				${LINUXBASE}/sbin/ldconfig
+LDCONFIG_CMD?=			${LINUXBASE}/sbin/ldconfig -r ${LINUXBASE}
 LDCONFIG_PLIST_EXEC_CMD?=	${LDCONFIG_CMD}
 LDCONFIG_PLIST_UNEXEC_CMD?=	${LDCONFIG_CMD}
 .else
--- bsd.port.mk.diff ends here ---



>Release-Note:
>Audit-Trail:
>Unformatted: