ports/91775: New port: graphics/gnash GNU Flash movie player

[Sergey Matveychuk]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dmitry Marakasov wrote:
> * Sergey Matveychuk (sem at FreeBSD.org) wrote:
>  
> 
>>1) I think it's better to use a version number for port number, not
>>snapshot. Just like that:
>>PORTVERSION=0.7
>>DISTNAME=${PORTNAME}-20051226
> 
> That's nonapparent. It's strange that newborn project has version 0.7,
> maybe the version won't be changed between snapshot releases.
> Still I've changed the version, as 0.7 can be easily changed back to
> 2006xxxx style without bumping the PORTEPOCH, if it's needed.

I thought the same way. I prefer use a `normal' version scheme where
it's possible.

>>2) It's better to use not only MASTER_SITE but mirrors too
>>(MASTER_SITE_GNU).
> 
> I didn't find gnash on any of MASTER_SITE_GNU. Seems like it's only
> available from current MASTER_SITE for now.

Ok. May be later it'll appear somewhere else.

>>3) Problem with ldconfig will be appeared after reboot. You should
>>either place shared libs in a common place (PREFIX/lib) or use RC script
>>to run ldconfig on booting (like mysql-client do).
> 
> I've found a better way to fix that, by adding -Wl,--rpath to LDFLAGS.
> So no mess in PREFIX/lib and no unnecessary scripts in rc.d :)

It's looks OK for me.

>>4) I'm not sure how .omf file should be processed but it should some way
>>(see INSTALLS_OMF in bsd.gnome.mk). Using of USE_GNOME=something will
>>fix an extra dirs problem (Ion-Mihai Tetcu pointed to).
>>I'm not familar with a GNOME stuff but I'll try to clarify how it should
>>be processed.
> 
> Yes, thanks for the hint. USE_GNOME=gnomehier does the thing.

Yes, but for INSTALL_OMF we need depend on scrollkeeper. I'm not sure
it's necessary for the port, so I've remarked a line with INSTALL_OMF.

> 
> Here's updated version of the port.

It's ready to commit. But for a next update investigate about
scrollkeeper and think if it's possible to get rid of .la files. They're
almost always useless. But it's not a law, so feel free here.

- --
Dixi.
Sem.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDyWFrTclL2LcfYF0RAk5GAJ4yaIoOQ+CBgVfE2EyeuU8pgdHWRwCfQcjC
vg2m40zFaYG9LlCJgngk7Vw=
=t38D
-----END PGP SIGNATURE-----