ports/93873: PORTS: Mk/bsd.ports.mk contains invalid .if syntax for old 4.x make(1)

[Eric Cronin]

>Number:         93873
>Category:       ports
>Synopsis:       PORTS: Mk/bsd.ports.mk contains invalid .if syntax for old 4.x make(1)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 26 20:40:07 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Eric Cronin
>Release:        4.7
>Organization:
>Environment:
FreeBSD widget.gizmolabs.org 4.7-RELEASE-p27-jc3 FreeBSD 4.7-RELEASE-p27-jc3 #4: Mon Dec 13 20:30:47 PST 2004     user at jail11.johncompanies.com:/usr/obj/usr/src/sys/jail11  i386
>Description:
Recent 1.527 commit uses new make(1) syntax for complex if statement, causes errors on systems using older 4.x make(1).
>How-To-Repeat:
build anything sucking in Mk/bsd.port.mk on a 4.x machine using the old version of make(1)
>Fix:
--- bsd.port.mk Thu Feb 23 10:37:20 2006
+++ bsd.port.mk.4x      Sun Feb 26 15:16:49 2006
@@ -5072,7 +5072,7 @@
 .if defined(USE_RC_SUBR) && ${USE_RC_SUBR:U} != "YES"
        @${ECHO_CMD} "===> Installing rc.d startup script(s)"
        @${ECHO_CMD} "@cwd ${PREFIX}" >> ${TMPPLIST}
-.if (${OSVERSION} >= 700007 || (${OSVERSION} < 700000 && ${OSVERSION} >= 600101))
+.if (${OSVERSION} >= 700007 || ( ${OSVERSION} < 700000 && ${OSVERSION} >= 600101 ))
        @for i in ${USE_RC_SUBR}; do \
                ${INSTALL_SCRIPT} ${WRKDIR}/$${i} ${PREFIX}/etc/rc.d/$${i%.sh}; \
                ${ECHO_CMD} "etc/rc.d/$${i%.sh}" >> ${TMPPLIST}; \
>Release-Note:
>Audit-Trail:
>Unformatted: