ports/93100: emulators/vmware-tools5 fails to build when WITH_VMWARE_GTK defined

[Scot Hetzel]

>Number:         93100
>Category:       ports
>Synopsis:       emulators/vmware-tools5 fails to build when WITH_VMWARE_GTK defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 09 16:40:05 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Scot Hetzel
>Release:        FreeBSD 5.x
>Organization:
>Environment:
>Description:
When I try to build/install the vmware-tools5 port, I receive several error message from make:
"/usr/ports/Mk/bsd.gnome.mk", line 605: "Malformed conditional (${_USE_GNOME_ALL:Mglib12=="")
"/usr/ports/Mk/bsd.gnome.mk", line 605: Need an operator
"/usr/ports/Mk/bsd.gnome.mk", line 605: Malformed conditional (${_USE_GNOME_ALL:Mgtk12}=="")
"/usr/ports/Mk/bsd.gnome.mk", line 605: Need an operator

The cause of this problem is that 'USE_GNOME= glib12 gtk12' is defined below bsd.port.pre.mk.  If it is defined above bsd.port.pre.mk, then this error doesn't occur.

After I fixed this problem, I discovered that the port would fail when installing the X server VM-Ware modules.  The reason it failed is because the ${X11BASE}/lib/modules/input directory wasn't created (affects xorg, and XFree86-4).  The port will also fail when there is no ${X11BASE}/lib/modules/drivers direcotory when installed on a system with XFree86-4.  The reason for these failures is that the mtree files BSD.x11-4.dist and BSD.x11.dist don't create these sub directories.
>How-To-Repeat:
cd /usr/ports/emulators/vmware-tools5
make WITH_VMWARE_GTK=yes extract

"/usr/ports/Mk/bsd.gnome.mk", line 605: Malformed conditional (${_USE_GNOME_ALL:Mglib12}=="")
"/usr/ports/Mk/bsd.gnome.mk", line 605: Need an operator
"/usr/ports/Mk/bsd.gnome.mk", line 605: Malformed conditional (${_USE_GNOME_ALL:Mgtk12}=="")
"/usr/ports/Mk/bsd.gnome.mk", line 605: Need an operator
"/usr/ports/Mk/bsd.port.mk", line 1835: if-less endif
"/usr/ports/Mk/bsd.port.mk", line 1835: Need an operator
"/usr/ports/Mk/bsd.port.mk", line 5442: if-less endif
"/usr/ports/Mk/bsd.port.mk", line 5442: Need an operator
make: fatal errors encountered -- cannot continue

>Fix:
See the followup email with the fix.
>Release-Note:
>Audit-Trail:
>Unformatted: