ports/106422: GraphicsMagick utility.c:3886: `message_p' undeclared

[Mark Worsdall]

>Number:         106422
>Category:       ports
>Synopsis:       GraphicsMagick utility.c:3886: `message_p' undeclared
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 06 19:00:19 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Mark Worsdall
>Release:        4.11 stable
>Organization:
Me
>Environment:
uname -a
FreeBSD DorisDay 4.11-STABLE FreeBSD 4.11-STABLE #0: Tue Sep 19 11:13:45 BST 2006     root at DorisDay:/usr/src/sys/compile/DORISDAY4_11_03  i386
>Description:
During a portupgrade to 1.1.7 of GraphicsMagick the following stop occurred when compiling utility.c:

The error:-

** Fix the problem and try again.
** Listing the failed packages (*:skipped / !:failed)
! graphics/GraphicsMagick (GraphicsMagick-1.1.6_3) (compiler error)
---> Packages processed: 0 done, 0 ignored, 0 skipped and 1 failed
-su-2.05b# cd /usr/ports/graphics/GraphicsMagick
-su-2.05b# make
===> Building for GraphicsMagick-1.1.7
Making all in ltdl
Making all in config
Making all in coders
Making all in filters
Making all in magick
make all-am
source='utility.c' object='utility.lo' libtool=yes DEPDIR=.deps depmode=gcc /bin/sh ../depcomp /bin/sh ../libtool --silent --mode=compile cc -DHAVE_CONFIG_H -I../ -I. -I. -I. -I. -I.. -I.. -I../ltdl -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11R6/include -I/usr/X11R6/include/X11 -I/usr/local/include/libxml2 -O -pipe -march=pentiumpro -Wall -c -o utility.lo utility.c
utility.c: In function `GmSystemCommand':
utility.c:3885: syntax error before `const'
utility.c:3886: `message_p' undeclared (first use in this function)
utility.c:3886: (Each undeclared identifier is reported only once
utility.c:3886: for each function it appears in.)
*** Error code 1

Stop in /usr/ports/graphics/GraphicsMagick/work/GraphicsMagick-1.1.7/magick.
*** Error code 1

Stop in /usr/ports/graphics/GraphicsMagick/work/GraphicsMagick-1.1.7/magick.
*** Error code 1

Stop in /usr/ports/graphics/GraphicsMagick/work/GraphicsMagick-1.1.7.
*** Error code 1

Stop in /usr/ports/graphics/GraphicsMagick.



>How-To-Repeat:

>Fix:
just moved the declaration above the if bit.

Here is the diff o/p.

3879a3880,3882
> const char
> *message_p = (const char *) NULL;
>
3885,3886d3887
< const char
< *message_p = (const char *) NULL;


but the easiest thing to do is not apply the patch file:

ls -l files
total 10
-rw-r--r--  1 root  wheel  3373 Jul 27  2005 patch-Makefile.in
-rw-r--r--  1 root  wheel  1099 Aug 21 11:34 patch-coders-png.c
-rw-r--r--  1 root  wheel  1233 Jul 27  2005 patch-configure
-rw-r--r--  1 root  wheel   541 Jul 27  2005 patch-utility
-su-2.05b# cat files/patch-utility
--- magick/utility.c   Sat Apr  2 17:35:06 2005
+++ magick/utility.c   Sun Jul 24 18:22:40 2005
@@ -47,4 +47,8 @@
 #include "magick/utility.h"

+#if defined(POSIX)
+#     include <sys/types.h>
+#     include <sys/wait.h>
+#endif

 /*
@@ -3874,4 +3878,9 @@
 #if defined(POSIX)
   status=system(command);
+  if (status == -1)
+      perror(command);
+  else if (WIFSIGNALED(status)) {
+      fprintf(stderr, "Command ``\n%s\n'' terminated due to signal %d\n", command, WTERMSIG(status));
+  }
 #elif defined(vms)
   status=!system(command);

>Release-Note:
>Audit-Trail:
>Unformatted: