ports/87518: [fix] multimedia/pvr250: Does not build on amd64

[Simun Mikecin]

>Number:         87518
>Category:       ports
>Synopsis:       [fix] multimedia/pvr250: Does not build on amd64
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 16 13:40:16 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Simun Mikecin
>Release:        FreeBSD 6.0-RC1 amd64
>Organization:
>Environment:
System: FreeBSD data.home.hr 6.0-RC1 FreeBSD 6.0-RC1 #0: Sun Oct 16 05:22:12 CEST 2005 root at data:/var/obj/usr/src/sys/DATA amd64


	
>Description:
On FreeBSD/amd64 bus_space_handle_t and bus_space_tag_t are defined as
64-bit (see sys/amd64/include/_bus.h). cxm_i2c.c calls BUS_READ_IVAR macro
using 'unsigned int' (which is 32-bit on amd64) as the last parameter, where
it should be bus_space_handle_t.
On FreeBSD 6.x warning is emitted and compilation stops (6.x has implicit
-Werror).
Current multimedia/pvr250 port doesn't build on FreeBSD 6.x at all. That
problem is already addressed in ports/85433 which is still not commited as
of this writing. All testing was done with patches from that PR already
applied.
>How-To-Repeat:
Try this on FreeBSD/amd64:
	cd /usr/ports/multimedia/pvr250 && make
>Fix:
--- cxm_i2c.c.orig	Sun Oct 16 15:13:45 2005
+++ cxm_i2c.c	Sun Oct 16 15:14:37 2005
@@ -156,8 +156,8 @@
 	int numkids;
 	int i;
 	int unit;
-	unsigned int bhandle;
-	unsigned int btag;
+	bus_space_handle_t bhandle;
+	bus_space_tag_t btag;
 	struct cxm_iic_softc *sc;
 
 	/* Get the device data */
>Release-Note:
>Audit-Trail:
>Unformatted: