ports/89614: [fix] multimedia/fxtv: segfaults while changing stations

[Simun Mikecin]

>Number:         89614
>Category:       ports
>Synopsis:       [fix] multimedia/fxtv: segfaults while changing stations
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 27 01:10:06 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Simun Mikecin
>Release:        FreeBSD 6.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD data.home.hr 6.0-STABLE FreeBSD 6.0-STABLE #1: Sat Nov 26 18:42:00 CET 2005 root at data.home.hr:/var/obj/usr/src.6/sys/DATA amd64
using "nv" driver from Xorg (GeForce 6600GT).
>Description:
Changing channels in fxtv tends to crash it with Segmentation fault. It doesn't happen all the time, but if you try to change stations fast your will surely encounter it.
I never experienced those kind of crashes on my previous PC (FreeBSD/i386 + GeForce 4 Ti4800SE + nvidia binary driver)
Since applying this fix I haven't encountered a single segfault.
>How-To-Repeat:
See description.
>Fix:
this is a replacement file for the /usr/ports/multimedia/fxtv/files/patch-tvmenu.c:
--- tvmenu.c.orig	Mon Feb 12 22:19:33 2001
+++ tvmenu.c	Sun Nov 27 01:55:24 2005
@@ -552,7 +552,7 @@
     Widget popup_win, new_popup_item = NULL;
     Cardinal num_children, i;
     WidgetList children;
-    String actual_station, temp_station;
+    String actual_station = NULL, temp_station = NULL;
 #ifdef FIXME
     Pixmap pix;
 #endif
@@ -589,7 +589,7 @@
 
         XtVaSetValues(children[i], XtNleftBitmap, pix, NULL);
 #else
-        if ( strcmp( actual_station, temp_station ) == 0 )
+        if ( strcmp( actual_station==NULL ? "" : actual_station, temp_station==NULL ? "" : temp_station ) == 0 )
             new_popup_item = children[i];
 #endif
     }
>Release-Note:
>Audit-Trail:
>Unformatted: