ports/80577: typos in gdm.sh

[Stefan Thurner]

>Number:         80577
>Category:       ports
>Synopsis:       typos in gdm.sh
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 03 12:20:01 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Stefan Thurner
>Release:        4.11-STABLE
>Organization:
TU Chemnitz
>Environment:
FreeBSD xris.fu41.vpn 4.11-STABLE FreeBSD 4.11-STABLE #0: Tue Apr 12
17:50:07 CEST 2005     root at xris.fu41.vpn:/usr/obj/usr/src/sys/CUSTOM
i386      
>Description:
1)
The gdm.sh script uses the echo command for output to the console. But the echo command is used without the "-n" option. So a linefeed is done after the output. If there are other local services started or stopped after gdm the output of these scripts is printed on a new line at the console. 
This is not the typical way services printing output to console during intialization or shutdown.

2)
Two more typos are the trailing space " " and dot ". " in the output text of the start and stop command.
Because every service which prints output to the console has only a leading space in the output text. So only one space is printed at the console between to services.
>How-To-Repeat:
Reboot your system and look at the console during intialization of local  services.
To see the problem one or more services should be started or stopped after gdm. 
>Fix:
A diff would look like this:

--- gdm.sh.in.orig      Tue May  3 13:38:55 2005
+++ gdm.sh.in   Tue May  3 13:40:36 2005
@@ -17,12 +17,12 @@
 pidfile="/var/run/${name}.pid"
 
 gdm_start() {
-    checkyesno gdm_enable && echo " Starting GDM " && \
+    checkyesno gdm_enable && echo -n " Starting GDM" && \
        ${command}
 }
 
 gdm_stop() {
-    checkyesno gdm_enable && echo " Stopping GDM. " && \
+    checkyesno gdm_enable && echo -n " Stopping GDM" && \
        /usr/bin/killall -m ${name} 2>/dev/null
 }
>Release-Note:
>Audit-Trail:
>Unformatted: