ports/76330: editors/openoffice-1.1 calls uname needlessly

Colin Percival cperciva at hexahedron.daemonology.net
Mon Jan 17 04:40:38 UTC 2005


>Number:         76330
>Category:       ports
>Synopsis:       editors/openoffice-1.1 calls uname needlessly
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 17 04:40:37 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Colin Percival
>Release:        FreeBSD 5.3-SECURITY i386
>Organization:
>Environment:
System: FreeBSD hexahedron.daemonology.net 5.3-SECURITY FreeBSD 5.3-SECURITY #0: Fri Jan 7 04:09:28 UTC 2005 root at builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386

>Description:

editors/openoffice-1.1/Makefile generates SIMPLEOSVER by parsing the 
output of `uname -r`.  This is pointless, since the same data can be
obtained from the (already generated) OSREL variable.

>How-To-Repeat:
>Fix:

--- oo.diff begins here ---
Index: ports/editors/openoffice-1.1/Makefile
===================================================================
RCS file: /home/pcvs/ports/editors/openoffice-1.1/Makefile,v
retrieving revision 1.173
diff -u -p -r1.173 Makefile
--- ports/editors/openoffice-1.1/Makefile	16 Jan 2005 08:47:09 -0000	1.173
+++ ports/editors/openoffice-1.1/Makefile	17 Jan 2005 04:32:36 -0000
@@ -82,7 +82,7 @@ RELEASE_NR=		${PORTVERSION}
 INSTALLATION_BASEDIR=	OpenOffice.org${RELEASE_NR}
 EXECBASE=		openoffice.org-${RELEASE_NR}
 DIST_SUBDIR=		openoffice1.1
-SIMPLEOSVER!=		${UNAME} -r | ${SED} -e 's/\.//g' | ${SED} -e 's/-.*//'
+SIMPLEOSVER=		${OSREL:C/\.//g}
 PACKAGE_BASENAME=       OOo_${PORTVERSION}_${OPSYS}${SIMPLEOSVER}Intel
 
 # FIXME (Somehow INDEX build fails)
--- oo.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list