ports/76258: games/scummvm: WITH_MPEG2 needs WITH_VORBIS to compile

[Bartosz Fabianowski]

>Number:         76258
>Category:       ports
>Synopsis:       games/scummvm: WITH_MPEG2 needs WITH_VORBIS to compile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 15 01:20:14 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Bartosz Fabianowski
>Release:        5.3-STABLE
>Organization:
>Environment:
FreeBSD takahe.local 5.3-STABLE FreeBSD 5.3-STABLE #0: Mon Jan 10 17:24:38 CET 2005     root at takahe.local:/usr/obj/usr/src/sys/TAKAHE  i386
>Description:
As of 0.7.0, games/scummvm cannot be compiled with MPEG2 support if Vorbis support is not enabled as well. The problem is the file sword1/animation.cpp. When WITH_MPEG2 is set, in line 121 of this file, makeVorbisStream is called unconditionally. Unfortunately, this is a Vorbis library function and is not defined if WITH_VORBIS is not set as well.


 is called no matter wheter USE_VORBIS is set or not.
>How-To-Repeat:
[make sure to remove /var/db/ports/scummvm/options]

cd /usr/ports/games/scummvm
make WITH_MPEG2=yes

[wait for compiler error]
>Fix:
The simplest fix would be to make WITH_MPEG2 depend on WITH_VORBIS. 

Another way of fixing this would be to change the source code, but from looking at the code it seems that the Vorbis support is necessary for the relevant code section to perform its intended job.
>Release-Note:
>Audit-Trail:
>Unformatted: