ports/76062: [ maintainer ] audio/xmms-scrobbler: add WITH_XMMS and WITH_BMP knobs, minor fixes

[Roman Bogorodskiy]

>Number:         76062
>Category:       ports
>Synopsis:       [ maintainer ] audio/xmms-scrobbler: add WITH_XMMS and WITH_BMP knobs, minor fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 10 17:10:23 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Roman Bogorodskiy
>Release:        FreeBSD 5.3-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD lame.novel.ru 5.3-RELEASE-p2 FreeBSD 5.3-RELEASE-p2 #3: Sat Dec 11 21:01:26 MSK 2004 root at lame.novel.ru:/usr/obj/usr/src/sys/MIRRORBOX i386


>Description:
	Some tweaks for audio/xmms-scrobbler:
	- add WITH_XMMS and WITH_BMP knobs to allow users to choose 
	which plugin they actually want.
	- remove pkg-plist, use PLIST_FILES instead
	- COMMENT: s/bmp/BMP
	- bump PORTREVISION

	Removed files: pkg-plist

>How-To-Repeat:
>Fix:

--- port.xmms-scrobbler.diff begins here ---
diff -ru xmms-scrobbler.orig/Makefile xmms-scrobbler/Makefile
--- xmms-scrobbler.orig/Makefile	Mon Jan 10 19:02:05 2005
+++ xmms-scrobbler/Makefile	Mon Jan 10 19:53:56 2005
@@ -6,23 +6,59 @@
 
 PORTNAME=	xmms-scrobbler
 PORTVERSION=	0.3.6
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	http://static.audioscrobbler.com/plugins/
 
 MAINTAINER=	ports at FreeBSD.org
-COMMENT=	XMMS and bmp plugin for Audioscrobbler.com
+COMMENT=	XMMS and BMP plugin for Audioscrobbler.com
 
-LIB_DEPENDS=	xmms.4:${PORTSDIR}/multimedia/xmms \
-		beep.2:${PORTSDIR}/multimedia/beep-media-player \
-		musicbrainz.4:${PORTSDIR}/audio/libmusicbrainz \
+LIB_DEPENDS=	musicbrainz.4:${PORTSDIR}/audio/libmusicbrainz \
 		curl.3:${PORTSDIR}/ftp/curl
 
 GNU_CONFIGURE=	yes
-USE_GNOME=	gtk12 gtk20
 USE_BZIP2=	yes
+USE_GNOME=	#	
 USE_X_PREFIX=	yes
 USE_LIBTOOL_VER=15
 USE_GMAKE=	yes
 CONFIGURE_ENV+=	CPPFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib"
 
-.include <bsd.port.mk>
+PLIST_FILES=	%%BMP%%lib/bmp/General/libbmp_scrobbler.so \
+		%%XMMS%%lib/xmms/General/libxmms_scrobbler.so
+
+OPTIONS=	XMMS "XMMS plugin" on \
+		BMP "BMP plugin" on \
+		APE "prefer APE tags to ID3v2" off 
+
+.include <bsd.port.pre.mk>
+
+.if !defined(WITH_XMMS) && !defined(WITH_BMP)
+# if we have no WITH_XMMS or WITH_BMP defined build both plugins
+WITH_BMP=yes
+WITH_XMMS=yes
+.endif
+
+.if defined(WITH_XMMS)
+USE_GNOME+=	gtk12
+LIB_DEPENDS+=	xmms.4:${PORTSDIR}/multimedia/xmms
+PLIST_SUB+=	XMMS=""
+.else
+CONFIGURE_ARGS+=	--disable-xmms-plugin
+PLIST_SUB+=	XMMS="@comment "
+.endif
+
+.if defined(WITH_BMP)
+USE_GNOME+=	gtk20
+LIB_DEPENDS+=	beep.2:${PORTSDIR}/multimedia/beep-media-player
+PLIST_SUB+=	BMP=""
+.else
+CONFIGURE_ARGS+=	--disable-bmp-plugin
+PLIST_SUB+=	BMP="@comment "
+.endif
+
+.if defined(WITH_APE)
+CONFIGURE_ARGS+=	--enable-prefer-ape
+.endif
+
+.include <bsd.port.post.mk>
--- port.xmms-scrobbler.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: