ports/77394: The op port enables an annoying amount of debugging on stderr.

[Christopher Sean Hilton]

>Number:         77394
>Category:       ports
>Synopsis:       The op port enables an  annoying amount of debugging on stderr.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 11 17:50:18 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Christopher Sean Hilton
>Release:        FreeBSD 5.3-STABLE
>Organization:
Unorganized
>Environment:
# uname -a
FreeBSD alderaan.vindaloo.com 5.3-STABLE FreeBSD 5.3-STABLE #0: Wed Feb  9 23:16:25 EST 2005  root at alderaan:/usr/obj/usr/src/sys/GENERIC  i386
#
>Description:
      As built the op port generates a bunch of noisy output on stderr as it parses it's config file. I think this is debugging output for the op programmer. It makes the port less useful especially if the data on your tty was important before you ran op.
>How-To-Repeat:
      Build the op port. Configure it and run it.
>Fix:
Substitute this patch-lex.l for the on that ships with the port:

# cat files/patch-lex.l
--- lex.l.orig  Sun Jan 16 11:36:55 2005
+++ lex.l       Sun Jan 16 13:09:52 2005
@@ -10,10 +10,11 @@
 /* +-------------------------------------------------------------------+ */

 #include <stdio.h>
-#include <varargs.h>
+#include <stdarg.h>
 #include <ctype.h>
 #include "defs.h"

+static int     addarg();
 static cmd_t   *newcmd();
 char   *savestr();

@@ -47,15 +48,12 @@
 #include <sys/stat.h>
 #include <syslog.h>

-msg(va_alist)
- va_dcl
+msg(char *s,...)
 {
 #if 0
        va_list ap;
-       char    *s;

-       va_start(ap);
-       s = va_arg(ap, char *);
+       va_start(ap,s);
        fprintf(stderr,"line %d: ",yyline);
        vfprintf(stderr, s, ap);
        fputc('\n', stderr);


>Release-Note:
>Audit-Trail:
>Unformatted: