ports/84497: security/tor startup script bug

[Stefan `Sec` Zehl]

>Number:         84497
>Category:       ports
>Synopsis:       security/tor startup script bug
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 02 21:20:15 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Stefan `Sec` Zehl
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD mcp 5.4-STABLE FreeBSD 5.4-STABLE #2: Sat May 21 16:20:09 CEST 2005     root at mcp:/enc/obj/enc/src/sys/MCP  i386

"tor" port installed.

>Description:

the installed /usr/local/etc/rc.d/tor.sh.sample file is broken, it fails to
start tor because of a misorder in the parameter list
	
>How-To-Repeat:

(as root)

mcp:/usr/local/etc/rc.d#sh tor.sh.sample start 
Starting tor...$ 

(now we are running a "_tor" subshell)

	
>Fix:

--- tor.sh.sample       Tue Aug  2 22:43:09 2005
+++ tor.sh      Tue Aug  2 23:05:06 2005
@@ -48,7 +48,7 @@
         if  [ "x$TORUSER" = "x" ]; then
             $TORBIN -f $TORCONF $TORARGS
         else
-            $SUPROG -c "$TORBIN -f $TORCONF $TORARGS" $TORUSER
+            $SUPROG $TORUSER -c "$TORBIN -f $TORCONF $TORARGS"
         fi
         RETVAL=$?
         if [ $RETVAL -eq 0 ]; then


	


>Release-Note:
>Audit-Trail:
>Unformatted: