ports/79654: perforce fails to install as non-root

[John Baldwin]

>Number:         79654
>Category:       ports
>Synopsis:       perforce fails to install as non-root
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 07 21:00:17 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     John Baldwin
>Release:        6.0-CURRENT
>Organization:
>Environment:
n/a      
>Description:
The pre-install target is run as the user that invoked 'make install'.  If this user is not root, they can't create files or directories under ${PREFIX}.      
>How-To-Repeat:
      
>Fix:
Use pre-su-install instead:

Index: Makefile
===================================================================
RCS file: /usr/cvs/ports/devel/perforce/Makefile,v
retrieving revision 1.44
diff -u -r1.44 Makefile
--- Makefile    10 Mar 2005 15:23:17 -0000      1.44
+++ Makefile    6 Apr 2005 15:17:14 -0000
@@ -97,7 +97,7 @@
        ${SED} -e "s, at PREFIX@,${PREFIX},g" \
                < ${FILESDIR}/perforce.sh.in > ${WRKSRC}/perforce.sh

-pre-install:
+pre-su-install:
        ${SETENV} PKG_PREFIX=${PREFIX} \
                PERFORCE_USER=${PERFORCE_USER} \
                PERFORCE_UID=${PERFORCE_UID} \

>Release-Note:
>Audit-Trail:
>Unformatted: