ports/72137: make clean crashes in x11/nvidia-driver too.

[Michel Lavondes]

>Number:         72137
>Category:       ports
>Synopsis:       make clean crashes in x11/nvidia-driver too.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 27 22:10:36 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Michel Lavondes
>Release:        4.8-RELEASE-p25
>Organization:
Ecdysiasts United for Overdressing
>Environment:
>Description:
# cd /usr/ports/x11/nvidia-driver; make clean
"Makefile", line 44: warning: String comparison operator should be either == or !=
"Makefile", line 44: Malformed conditional (${OSVERSION} < 490000 || (${OSVERSION} >= 500000 && ${OSVERSION} < 502001))
"Makefile", line 44: Missing dependency operator
"Makefile", line 46: if-less endif
"Makefile", line 46: Need an operator
make: fatal errors encountered -- cannot continue

Note: this is a near-duplicate of ports/72118, http://www.freebsd.org/cgi/query-pr.cgi?pr=72118


>How-To-Repeat:
See above "Full Description"
>Fix:
Change line 44 of Makefile from:

.if ${OSVERSION} < 490000 || (${OSVERSION} >= 500000 && ${OSVERSION} < 502001)

to

.if ${OSVERSION} < 490000 || ${OSVERSION} >= 500000 && ${OSVERSION} < 502001

Note: make(1) states that && has higher precedence than ||, so the () shouldn't be necessary. Just to be on the safe side (I don't have the resources to test on other FreeBSD versions), I checked my fix with: 

# make -V OSVERSION
480000
# make -V IGNORE
"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
# make -V IGNORE OSVERSION=489999
"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
# make -V IGNORE OSVERSION=490000

# make -V IGNORE OSVERSION=499999

# make -V IGNORE OSVERSION=500000
"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
# make -V IGNORE OSVERSION=502000
"supports FreeBSD -STABLE (4.9 or later), or FreeBSD -CURRENT (5.2.1 or later)"
# 

I hope I didn't overlook anything.
>Release-Note:
>Audit-Trail:
>Unformatted: