ports/72118: port dns/bind9 Makefile 1.59 crashes "make clean"

[Michel Lavondes]

>Number:         72118
>Category:       ports
>Synopsis:       port dns/bind9 Makefile 1.59 crashes "make clean"
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 26 22:50:25 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Michel Lavondes
>Release:        4.8-RELEASE-p25
>Organization:
Ecdysiasts United for Overdressing
>Environment:
>Description:
A syntax error was introduced as part of http://docs.FreeBSD.org/cgi/mid.cgi?200409240403.i8O43VEY089224

This crashes on "make clean" in /usr/ports/dns/bind9 with the following error messages:
# make clean
"Makefile", line 37: warning: String comparison operator should be either == or !=
"Makefile", line 37: Malformed conditional ((${OSVERSION} >= 503000))
"Makefile", line 37: Missing dependency operator
"Makefile", line 39: if-less else
"Makefile", line 39: Need an operator
"Makefile", line 41: if-less endif
"Makefile", line 41: Need an operator
make: fatal errors encountered -- cannot continue

It also crashes on "make clean" in /usr/ports/dns and /usr/ports (that's when I first noticed it), and on "make fetch" (and I suspect other targets too) in dns/bind9.

>How-To-Repeat:
# cd /usr/ports/dns/bind9; make clean
>Fix:
The following change unbreaks it on my machine:

Change line 37 of Makefile,

.if (${OSVERSION} >= 503000)

to:

.if ${OSVERSION} >= 503000

(remove parentheses around the condition)
>Release-Note:
>Audit-Trail:
>Unformatted: