ports/72002: Update port: graphics/deng dependency fix

Thierry Thomas thierry at FreeBSD.org
Fri Sep 24 19:55:24 UTC 2004


Le Ven 24 sep 04 à 20:16:39 +0200, Igor Pokrovsky <ip at doom.homeunix.org>
 écrivait :
> You are right. Your patch is fine. Commit it please.

Thanks Igor, I'm going to ask portmgr for approval.

> However I have a question. Why bsd.port.pre.mk is not required in this case.
> I thought that we need it to resolve ${LOCALBASE} on the early stage. 
> Am I wrong?

$LOCALBASE is a simple variable, always evaluated. I don't know why
bsd.port.pre.mk was required, perhaps there was previously a complex
test? By "complex", I mean some variable not directly evaluated, like
$OSVERSION, which implies bsd.port.pre.mk.

> And another thing. I used BUILD_DEPENDS and RUN_DEPENDS together instead
> of simply LIB_DEPENDS because AFAIR portlint was complaining about
> placing LIB_DEPENDS so late in makefile. So I see it's not the case now?

Because you was using strict "=" and now I'm using "+=".

Regards,
-- 
Th. Thomas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/attachments/20040924/89e112cd/attachment.sig>


More information about the freebsd-ports-bugs mailing list