ports/73346: www/firefox compile breaks due to missing "#include ft2build.h" line

[ino-qc at spotteswoode.dnsalias.org]

>Number:         73346
>Category:       ports
>Synopsis:       www/firefox compile breaks due to missing "#include ft2build.h" line
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 31 14:10:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     clemens fischer, ino-qc at spotteswoode.dnsalias.org
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
rarely
>Environment:

System: FreeBSD spotteswoode.dnsalias.org 4.10-STABLE FreeBSD
4.10-STABLE #15: Sat Oct 30 18:14:29 CEST 2004
root at spotteswoode.dnsalias.org:/mail/freebsd/obj/mail/freebsd/RELENG_4/src/sys/n1
i386

>Description:

using "portinstall www/firefox", watch the compilation break with the
following message, which appears the same on files:

"work/mozilla/gfx/src/gtk/nsDeviceContextGTK.cpp"
"work/mozilla/gfx/src/gtk/nsDrawingSurfaceGTK.cpp"
"work/mozilla/gfx/src/gtk/nsFontMetricsUtils.cpp"
"work/mozilla/gfx/src/gtk/nsFontMetricsXft.cpp"
"work/mozilla/gfx/src/gtk/nsGfxFactoryGTK.cpp"

--- snip ---
c++ -o nsDeviceContextGTK.o -c -DNATIVE_THEME_SUPPORT -DOSTYPE=\"FreeBSD4\" -DOSARCH=\"FreeBSD\" -DUSE_POSTSCRIPT -DUSE_XPRINT -DUSE_MOZILLA_TYPES -I../.. -I./. -I./.. -I./../shared -I./../freetype -I./../x11shared -I/usr/X11R6/include -I/usr/local/include/freetype2 -I/usr/local/include    -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/widget -I../../../dist/include/view -I../../../dist/include/util -I../../../dist/include/pref -I../../../dist/include/uconv -I../../../dist/include/unicharutil -I../../../dist/include/locale -I../../../dist/include/necko -I../../../dist/include/content -I../../../dist/include/dom -I../../../dist/include/layout -I../../../dist/include/imglib2 -I../../../dist/include/xprintutil -I../../../dist/include/gfx -I../../../dist/include -I/usr/ports/www/firefox/work/mozilla/dist/include/nspr  -I/usr/local/include -I/usr/local/include  -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11R6/include   -fPIC  -
 I/usr/X11R6/include -I/usr/local/include  -I/usr/X11R6/include  -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -O -pipe -D_THREAD_SAFE -fmemoize-lookups -fsave-memoized -pipe  -DNDEBUG -DTRIMMED -O  -I/usr/local/include/atk-1.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include -I/usr/X11R6/include/pango-1.0 -I/usr/X11R6/include -I/usr/local/include/freetype2 -I/usr/local/include    -I/usr/X11R6/include -I/usr/local/include  -I/usr/X11R6/include  -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h nsDeviceContextGTK.cpp
In file included from /usr/X11R6/include/X11/Xft/Xft.h:35,
                 from nsDeviceContextGTK.cpp:78:
/usr/local/include/freetype2/freetype/freetype.h:20: #error "`ft2build.h' hasn't been included yet!"
/usr/local/include/freetype2/freetype/freetype.h:21: #error "Please always use macros to include FreeType header files."
/usr/local/include/freetype2/freetype/freetype.h:22: #error "Example:"
/usr/local/include/freetype2/freetype/freetype.h:23: #error "  #include <ft2build.h>"
/usr/local/include/freetype2/freetype/freetype.h:24: #error "  #include FT_FREETYPE_H"
--- snip ---

>How-To-Repeat:

use "portinstall www/firefox" or "cd /ports/www/firefox && make install" and watch.

>Fix:

this is what i did:

 1556  041028-13:51 go firefox-mozilla-gtk2-browser-ports
 1557  041028-13:51 localname=$(pwd) && portupgrade -v ${localname#*/ports/}
 1559  041028-14:34 vi work/mozilla/gfx/src/gtk/nsDeviceContextGTK.cpp work/mozilla/gfx/src/gtk/nsDrawingSurfaceGTK.cpp work/mozilla/gfx/src/gtk/nsFontMetricsUtils.cpp work/mozilla/gfx/src/gtk/nsFontMetricsXft.cpp work/mozilla/gfx/src/gtk/nsGfxFactoryGTK.cpp

... and this is what needs to be done:

vi work/mozilla/gfx/src/gtk/nsDeviceContextGTK.cpp \
work/mozilla/gfx/src/gtk/nsDrawingSurfaceGTK.cpp \
work/mozilla/gfx/src/gtk/nsFontMetricsUtils.cpp \
work/mozilla/gfx/src/gtk/nsFontMetricsXft.cpp \
work/mozilla/gfx/src/gtk/nsGfxFactoryGTK.cpp

... and include the following line at/near the top:
--- snip ---
#include "ft2build.h"
--- snip ---

NB: i haven't checked if there's a more "central" header file to include
this line into!
>Release-Note:
>Audit-Trail:
>Unformatted: