ports/73126: [PATCH] devel/kdesdk3: fix off-by-one with moving list items in Umbrello

Stefan Walter sw at gegenunendlich.de
Mon Oct 25 15:50:25 UTC 2004

>Number:         73126
>Category:       ports
>Synopsis:       [PATCH] devel/kdesdk3: fix off-by-one with moving list items in Umbrello
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 25 15:50:25 GMT 2004
>Originator:     Stefan Walter
>Release:        FreeBSD 5.3-STABLE i386
Infinity Approximation Task Force
System: FreeBSD kyuzo.dunkelkammer.void 5.3-STABLE FreeBSD 5.3-STABLE #0: Sun Oct 24 12:54:09 CEST 2004 root at kyuzo.dunkelkammer.void:/usr/obj/usr/src/sys/KYUZO i386
When changing the order of operations or attributes of a class, using the
dialog's down button changes the order of items in the dialog list correctly,
but moves the item in the class itself down two slots (i.e. one too far).
Create a class with attributes and/or operations, then double-click on the
class to open its properties dialog. Choose 'operations' or 'attributes'.
Choose one of the attributes/operations and click on the 'down' arrow. The
chosen item will be moved down by one in the list, but two in the diagram.
The following patch fixes Umbrello's behaviour. Note that I haven't been able
to connect to http://webcvs.kde.org/ (all connections timed out so far), so I
don't know if this patch needs to be sent upstream, too, or if it's already
fixed there.

--- patch-umbrello:umbrello:dialogs:classifierlistpage.cpp begins here ---
--- umbrello/umbrello/dialogs/classifierlistpage.cpp.old	Mon Oct 25 16:09:31 2004
+++ umbrello/umbrello/dialogs/classifierlistpage.cpp	Mon Oct 25 16:09:56 2004
@@ -348,7 +348,7 @@
 	//now change around in the list
 	UMLClassifierListItem* currentAtt = getItemList().at( index );
-	addClassifier(currentAtt, index + 2);
+	addClassifier(currentAtt, index + 1);
 	slotClicked( item );
--- patch-umbrello:umbrello:dialogs:classifierlistpage.cpp ends here ---


More information about the freebsd-ports-bugs mailing list