ports/72856: graphics/png install fails which installing user sets LD_LIBRARY_PATH.

[maya]

>Number:         72856
>Category:       ports
>Synopsis:       graphics/png install fails which installing user sets LD_LIBRARY_PATH.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 19 02:40:24 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     maya
>Release:        4.10-p2
>Organization:
>Environment:
FreeBSD mail.negeta.com 4.10-RELEASE-p2 FreeBSD 4.10-RELEASE-p2 #12: Wed Sep  1 16:48:29 JST 2004     maya at mail.negeta.com:/usr/obj/usr/src/sys/Eden  i386
>Description:
I'm using FreeBSD-4.10 and I'm setting LD_LIBRARY_PATH
and I use portupgrade when I update png from the ports.

Well, I tryed to update png by "portupgrade -R graphics/png",
and install fails occur because pngtest not reffers ./libpng.so but 
it reffers /usr/local/lib/libpng.so(it is old version of one).
This version difference cause error.

Attached patch force specify LD_LIBRARY_PATH to . 
when pngtest is runing.
Please apply it if you look upon this as good.
>How-To-Repeat:
0. Old version of png was installed.
1. # sh && export LD_LIBRARY_PATH="/usr/local/lib:/usr/lib"
2. # cd /usr/ports/graphics/png && make
>Fix:
--- patch-aa	Wed Mar  3 15:03:56 2004
+++ patch-aa.new	Tue Oct 19 11:15:42 2004
@@ -1,5 +1,5 @@
---- scripts/makefile.freebsd	Sat May 18 10:46:45 2002
-+++ scripts/makefile.freebsd	Mon Oct 20 00:05:40 2003
+--- scripts/makefile.freebsd	Sat May 18 23:46:45 2002
++++ scripts/makefile.freebsd	Tue Oct 19 11:09:06 2004
 @@ -25,7 +25,7 @@
  DPADD+=         ${LIBM} ${LIBZ}
  
@@ -9,13 +9,20 @@
  CFLAGS+= -DPNG_NO_ASSEMBLER_CODE
  .endif
  
-@@ -34,7 +34,7 @@
+@@ -33,13 +33,13 @@
+ 	pngread.c pngrio.c pngwio.c pngwrite.c pngrtran.c \
  	pngwtran.c pngmem.c pngerror.c pngpread.c pnggccrd.c
  
 -pngtest: pngtest.o libpng.a
-+pngtest: pngtest.o ${SHLIB_NAME}
 -	${CC} ${CFLAGS} -L. -static -o pngtest pngtest.o -lpng -lz -lm
++pngtest: pngtest.o ${SHLIB_NAME}
 +	${CC} ${CFLAGS} -L. -Wl,-rpath=${.OBJDIR} -o pngtest pngtest.o -lpng -lz -lm
  
  CLEANFILES= pngtest pngtest.o pngout.png
  
+ test: pngtest
+-	./pngtest
++	env LD_LIBRARY_PATH=. ./pngtest
+ 
+ DOCS = ANNOUNCE CHANGES INSTALL KNOWNBUG LICENSE README TODO Y2KINFO
+ writelock:

>Release-Note:
>Audit-Trail:
>Unformatted: