ports/74009: sysutils/tree: make install fails for version 1.5.0

[Linh Pham]

>Number:         74009
>Category:       ports
>Synopsis:       sysutils/tree: make install fails for version 1.5.0
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 16 18:10:25 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Linh Pham
>Release:        FreeBSD 5.2.1-RELEASE-p11 i386
>Organization:
>Environment:
System: FreeBSD q.internal.closedsrc.org 5.2.1-RELEASE-p11 FreeBSD 5.2.1-RELEASE-p11 #3: Thu Oct 14 23:10:30 PDT 2004 question at q.internal.closedsrc.org:/usr/obj/usr/src/sys/Q i386
>Description:
When trying to install sysutils/tree, the port installation process fails
with the following error:

===>  Installing for tree-1.5.0
===>   Generating temporary packing list
===>  Checking if sysutils/tree already installed
/usr/local/bin
/usr/local/bin:Permission denied
*** Error code 1

Stop in /usr/ports/sysutils/tree/work/tree-1.5.0.
*** Error code 1

Stop in /usr/ports/sysutils/tree.

The problem is reproduceable on a 4.10 and 5.2.1

>How-To-Repeat:
fetch latest version of sysutils/tree
run: cd sysutils/tree ; make install
>Fix:
I compared the install portion of the extracted (and patched?) Makefile
from the distfile and noted a difference in the two versions:

>From version 1.3.0:
install: $(TREE_DEST) $(MAN)
        mkdir -p $(BINDIR)
        mkdir -p $(MANDIR)
        ${BSD_INSTALL_PROGRAM} $(TREE_DEST) $(BINDIR)
        ${BSD_INSTALL_MAN} $(MAN) $(MANDIR)

>From version 1.5.0:
install: $(TREE_DEST) $(MAN)
        $(MKDIR) $(BINDIR)
        $(MKDIR) $(MANDIR)
        ${BSD_INSTALL_PROGRAM} $(TREE_DEST) $(BINDIR)
        ${BSD_INSTALL_MAN} $(MAN) $(MANDIR)

Replacing the two $(MKDIR) with the respective "mkdir -p" lines from the
previous version results in a different error when trying to run a
"make install":

===>  Installing for tree-1.5.0
===>   Generating temporary packing list
===>  Checking if sysutils/tree already installed
"Makefile", line 51: Need an operator
make: fatal errors encountered -- cannot continue
*** Error code 1

Stop in /usr/ports/sysutils/tree.

>Release-Note:
>Audit-Trail:
>Unformatted: