ports/64233: [PATCH] bsd.port.mk: improved OPTIONS handling

Oliver Eikemeier eikemeier at fillmore-labs.com
Sun Mar 14 00:58:23 UTC 2004


Joe Marcus Clarke wrote:

> On Sat, 2004-03-13 at 19:37, Oliver Eikemeier wrote:
> 
>>Joe Marcus Clarke wrote:
>>
>>
>>>Maybe I'm missing something, but why do you have:
>>>
>>>cd ${.CURDIR} && ${MAKE} ABC=x ${__softMAKEFLAGS} ${.TARGET}; \
>>>
>>>What is ABC in this case?  Was it something left in from testing?
>>
>>Yep, sorry. Stupid me. This was a test to see *when* this is executed.
>>But I'm glad that at least someone is reading my patches ;)
> 
> Yes, I'm very interested in your patches.  I was trying to get some
> ideas about what to do with OPTIONS, and this seems to have addressed
> most of the problems.  The big concern I have right now is how this will
> work with make index.  Since make describe throws up the OPTIONS screen,
> that could put a dent in things.

That should be easy to resolve, but I'll appreciate some feedback before
I develop a solution. First of all, when BATCH or PACKAGE_BUILDING is set,
default options are used and no configuration dialog is presented.

So we can either set BATCH in INDEX builds or add another variable, like
DISABLE_CONFIG.

The issues here are:

- To generate default options I need to write them to a file. Currently
  I'm using the real OPTIONSFILE, so after a `make index' you have a
  saved default configuration for all ports that define OPTIONS. Maybe
  a temporary file would be a better solution here?

- I'm not sure what this does to running times of INDEX builds.

- OTOH we'll need this, since options can change the ports name and
  dependencies.

- If a port has saved options, should `make describe' use them or generate
  default options? As stated above, this could influence port names and
  dependencies.

-Oliver



More information about the freebsd-ports-bugs mailing list