ports/68215: NEW PORT: multimedia/freevo, an open-source home theatre PC platform

[Volker Stolz]

The following reply was made to PR ports/68215; it has been noted by GNATS.

From: "Volker Stolz" <vs at freebsd.org>
To: freebsd-gnats-submit at freebsd.org, purple at lewiz.net
Cc:  
Subject: Re: ports/68215: NEW PORT: multimedia/freevo, an open-source home theatre PC platform
Date: Fri, 25 Jun 2004 13:27:21 +0200

 ...
 # Should these have exists() ?
 # Without them freevo setup still detects applications but ports doesn't
 # create the full dependency list.
 .if defined(WITH_XINE)
 RUN_DEPENDS+=xine:${PORTSDIR}/multimedia/xine
 .endif
 
 This is not good. You should always record the exact dependencies.
 Please *also* use exists() ("... exists(foo) || defined(WITH_FOO)...".  
 Provide some sanity-checks,
 in case WITH_foo and autodetection conflict. Or maybe there's something  
 like configure's
 --disable-foo, which will prevent feature-detection?
 
 Volker