ports/67255: [PATCH] x11-toolkits/py23-kde: unbreak/update to 3.11.r1

[Thierry Thomas]

Synopsis: [PATCH] x11-toolkits/py23-kde: unbreak/update to 3.11.r1

State-Changed-From-To: open->feedback
State-Changed-By: thierry
State-Changed-When: Sat Jun 5 13:13:45 PDT 2004
State-Changed-Why: 

1) It builds and runs fine on FreeBSD-5.x, but installs
examples with a bad ownership if built by an user; I
propose the following patch:

diff -urN x11-toolkits/py-kde.orig/Makefile x11-toolkits/py-kde/Makefile
--- x11-toolkits/py-kde.orig/Makefile	Sat Jun  5 22:10:06 2004
+++ x11-toolkits/py-kde/Makefile	Sat Jun  5 21:01:00 2004
@@ -19,8 +19,6 @@
 
 BUILD_DEPENDS=	pyuic:${PORTSDIR}/x11-toolkits/py-qt
 
-WRKSRC=		${WRKDIR}/${DISTNAME}
-
 USE_PYTHON=	yes
 USE_KDELIBS_VER=3
 USE_REINPLACE=	yes
@@ -48,6 +46,7 @@
 	@${MKDIR} ${PREFIX}/share/examples/${PKGBASE}
 	@( cd ${WRKSRC}/examples && ${TAR} -cf - . ) | \
 		( cd ${PREFIX}/share/examples/${PKGBASE} && ${TAR} -xf - )
+	@${CHOWN} -R ${SHAREOWN}:${SHAREGRP} ${PREFIX}/share/examples/${PKGBASE}
 	@${INSTALL_SCRIPT} ${WRKSRC}/contrib/kdepyuic ${PREFIX}/bin
 
 .include <bsd.port.mk>

2) It is broken on -STABLE:

c++ -c -Wno-deprecated-declarations -pipe -fPIC -O -pipe -march=pentiumpro -Wall -W -D_THREAD_SAFE -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -I. -I../extra/kde322 -I/usr/local/include -I/usr/local/include/python2.3 -I/usr/X11R6/include -o sipkdecorepart0.o sipkdecorepart0.cpp
sipkdecorepart0.cpp: In function `const class KShortcut & sipVH_kdecore_35(PyGILState_STATE, PyObject *, unsigned int)':
sipkdecorepart0.cpp:5171: warning: reference to local variable `sipRes' returned
sipkdecorepart0.cpp: In function `const class QString & sipVH_kdecore_60(PyGILState_STATE, PyObject *)':
sipkdecorepart0.cpp:5574: warning: reference to local variable `sipRes' returned
sip/kdecore/kmountpoint.sip: In function `struct PyObject * convertFrom_KMountPoint_List(void *)':
sip/kdecore/kmountpoint.sip:137: warning: taking address of temporary
sipkdecorepart0.cpp: In function `int convertTo_Display(PyObject *, void **, int *)':
sipkdecorepart0.cpp:27824: warning: unused parameter `struct PyObject * sipPy'
sipkdecorepart0.cpp:27824: warning: unused parameter `int * sipIsErr'
sipkdecorepart0.cpp: In function `struct PyObject * convertFrom_Display(void *)':
sipkdecorepart0.cpp:27858: warning: unused variable `struct _XDisplay * sipCpp'
sipkdecorepart0.cpp: In method `const class KShortcut & sipKShortcutList::shortcutDefault(unsigned int) const':
sipkdecorepart0.cpp:51467: new cannot be applied to a reference type
sipkdecorepart0.cpp: In method `const class KShortcut & sipKShortcutList::shortcut(unsigned int) const':
sipkdecorepart0.cpp:51482: new cannot be applied to a reference type
sipkdecorepart0.cpp: In function `struct PyObject * convertFrom_ulonglong(void *)':
sip/kdecore/kconfigbase.sip:298: warning: unused variable `struct PyObject * LongLong'
sipkdecorepart0.cpp: In function `void dealloc_KShared(sipWrapper *)':
sipkdecorepart0.cpp:79446: warning: unused parameter `struct sipWrapper * sipSelf'
sipkdecorepart0.cpp: In function `struct PyObject * meth_KApplication_startServiceByName(PyObject *, PyObject *)':
sipkdecorepart0.cpp:93828: warning: `class QString * a2' might be used uninitialized in this function
sipkdecorepart0.cpp:93829: warning: `class QCString * a3' might be used uninitialized in this function
sipkdecorepart0.cpp:93859: warning: `class QString * a2' might be used uninitialized in this function
sipkdecorepart0.cpp:93860: warning: `class QCString * a3' might be used uninitialized in this function
sipkdecorepart0.cpp: In function `struct PyObject * meth_KApplication_startServiceByDesktopPath(PyObject *, PyObject *)':
sipkdecorepart0.cpp:93898: warning: `class QString * a2' might be used uninitialized in this function
sipkdecorepart0.cpp:93899: warning: `class QCString * a3' might be used uninitialized in this function
sipkdecorepart0.cpp:93929: warning: `class QString * a2' might be used uninitialized in this function
sipkdecorepart0.cpp:93930: warning: `class QCString * a3' might be used uninitialized in this function
sipkdecorepart0.cpp: In function `struct PyObject * meth_KApplication_startServiceByDesktopName(PyObject *, PyObject *)':
sipkdecorepart0.cpp:93968: warning: `class QString * a2' might be used uninitialized in this function
sipkdecorepart0.cpp:93969: warning: `class QCString * a3' might be used uninitialized in this function
sipkdecorepart0.cpp:93999: warning: `class QString * a2' might be used uninitialized in this function
sipkdecorepart0.cpp:94000: warning: `class QCString * a3' might be used uninitialized in this function
sipkdecorepart0.cpp: In function `struct PyObject * meth_KApplication_kdeinitExec(PyObject *, PyObject *)':
sipkdecorepart0.cpp:94067: warning: `class QString * a2' might be used uninitialized in this function
sipkdecorepart0.cpp: In function `struct PyObject * meth_KApplication_kdeinitExecWait(PyObject *, PyObject *)':
sipkdecorepart0.cpp:94128: warning: `class QString * a2' might be used uninitialized in this function
sipkdecorepart0.cpp: In function `struct PyObject * convertFrom_QMap_0200QChar_0200QStringList(void *)':
sip/kdecore/kmacroexpander.sip:272: warning: `struct PyObject * binst' might be used uninitialized in this function
sipkdecorepart0.cpp: In function `struct PyObject * convertFrom_QMap_0200KEntryKey_0200KEntry(void *)':
sip/kdecore/kconfigdata.sip:119: warning: `struct PyObject * binst' might be used uninitialized in this function
sipkdecorepart0.cpp: In function `struct PyObject * convertFrom_QMap_0200QString_0200QString(void *)':
sip/kdecore/kconfig.sip:129: warning: `struct PyObject * binst' might be used uninitialized in this function
sipkdecorepart0.cpp: In function `struct PyObject * convertFrom_QValueList_2100(void *)':
sip/kdecore/kwinmodule.sip:110: warning: unused variable `struct PyObject * inst'
/usr/X11R6/include/qptrlist.h: In method `void QPtrList<KIconThemeDir>::deleteItem(void *)':
sipkdecorepart0.cpp:101226:   instantiated from here
/usr/X11R6/include/qptrlist.h:150: invalid use of undefined type `class KIconThemeDir'
../extra/kde322/kicontheme.h:23: forward declaration of `class KIconThemeDir'
*** Error code 1

Stop in /usr/ports/x11-toolkits/py-kde/work/PyKDE-3.11rc1/kdecore.

Could you please fix it?


http://www.freebsd.org/cgi/query-pr.cgi?pr=67255