ports/68568: bsd.autotools.mk should not use `.error'

[Oliver Eikemeier]

>Number:         68568
>Category:       ports
>Synopsis:       bsd.autotools.mk should not use `.error'
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 01 20:30:31 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Oliver Eikemeier
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
Fillmore Labs - http://www.fillmore-labs.com
>Environment:
System: FreeBSD nuuk.fillmore-labs.com 4.10-STABLE

>Description:

bsd.autotools.mk uses `.error' in multiple places:

  135:. error USE_${i} deprecated: replace with USE_${i}_VER=...
  138:. error WANT_${i} deprecated: replace with WANT_${i}_VER=...
  165:. error Unknown AUTOMAKE version: ${WANT_AUTOMAKE_VER}
  210:.error Incompatible autoheader ${USE_AUTOHEADER_VER} and autoconf ${USE_AUTOCONF_VER}
  215:.error Incompatible autoheader ${WANT_AUTOHEADER_VER} and autoconf ${WANT_AUTOCONF_VER}
  232:. error Unknown AUTOCONF version: ${WANT_AUTOCONF_VER}
  282:. error Unknown LIBTOOL version: ${WANT_LIBTOOL_VER}

This has the ill effect that a misconfigured port breaks all port tools,
like INDEX building, pkg_version, portupgrade, chkversion and others.

I assume that tools that should report these misconfigurations, like
portsmon, are affected too.

Most port tools use make -V to extract information fro the ports,
so FreshPorts can do make -VPKGNAME -VBROKEN and could display that
port PKGNAME is broken because BROKEN.

Common practice in the ports tree is to set BROKEN in this case.

>How-To-Repeat:
>Fix:

Replace `.error' with `BROKEN='

>Release-Note:
>Audit-Trail:
>Unformatted: