ports/63505: [Patch] multimedia/libfame -- SSE support does not work right

[michael johnson]

>Number:         63505
>Category:       ports
>Synopsis:       [Patch] multimedia/libfame -- SSE support does not work right
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 28 09:40:11 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     michael johnson
>Release:        5.2-CURRENT
>Organization:
>Environment:
>Description:
The way SSE is enabled right now is backwards, if you define WITH_SSE it disables it and if you don't define WITH_SSE it is enabled.

I am submitting 2 patches to fix this. If we want SSE enabled default use patch1, if we want SSE to be enabled when defined use patch2.

Orignally in http://www.freebsd.org/cgi/query-pr.cgi?pr=63417 I choose to use patch2 because mplayer enables SSE default. 

Patch1  
  o Works the opposite of myplayer and disables it default and adds WITH_SSE
Patch2
   o Works the same way mplayer does, enables it default and adds WITHOUT_SSE 


>How-To-Repeat:
=== Begin Patch1 === 
diff -ruN multimedia/libfame.orig/Makefile multimedia/libfame/Makefile
--- multimedia/libfame.orig/Makefile	Sat Feb 28 12:15:17 2004
+++ multimedia/libfame/Makefile	Sat Feb 28 12:25:50 2004
@@ -18,7 +18,7 @@
 USE_LIBTOOL=	yes
 INSTALLS_SHLIB=	yes
 
-.if !defined(WITH_SSE)
+.if defined(WITH_SSE)
 CONFIGURE_ARGS+=	--enable-sse
 .endif
 
@@ -33,7 +33,7 @@
 	fame_start_frame.3 fame_end_frame.3
 
 pre-everything::
-.if !defined(WITHOUT_SSE)
+.if !defined(WITH_SSE)
 	@${ECHO_MSG} " You can enable SSE optimized routines by defining WITH_SSE."
 	@${ECHO_MSG} ""
 .endif
=== End Patch1 ===

=== Begin Patch2 ===
diff -ruN multimedia/libfame.orig/Makefile multimedia/libfame/Makefile
--- multimedia/libfame.orig/Makefile	Sat Feb 28 12:15:17 2004
+++ multimedia/libfame/Makefile	Sat Feb 28 12:30:06 2004
@@ -18,7 +18,7 @@
 USE_LIBTOOL=	yes
 INSTALLS_SHLIB=	yes
 
-.if !defined(WITH_SSE)
+.if !defined(WITHOUT_SSE)
 CONFIGURE_ARGS+=	--enable-sse
 .endif
 
@@ -34,7 +34,7 @@
 
 pre-everything::
 .if !defined(WITHOUT_SSE)
-	@${ECHO_MSG} " You can enable SSE optimized routines by defining WITH_SSE."
+	@${ECHO_MSG} " You can disable SSE optimized routines by defining WITHOUT_SSE."
 	@${ECHO_MSG} ""
 .endif
=== End Patch2 ===
>Fix:
      
>Release-Note:
>Audit-Trail:
>Unformatted: