ports/70594: [PATCH] net-mgmt/mbrowse: let it compile with gcc342 on -Current

[Paul Seniura]

>Number:         70594
>Category:       ports
>Synopsis:       [PATCH] net-mgmt/mbrowse: fix compile with gcc342 on -Current
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 17 22:00:45 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     "Paul Seniura" <pdseniura at techie.com>
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
State of Okla. D.O.T.
>Environment:
System: FreeBSD techpc04.okladot.state.ok.us 5.2-CURRENT FreeBSD 5.2-CURRENT #2: Tue Aug 17 14:17:21 CDT 2004 root at techpc04.okladot.state.ok.us:/usr/obj/src/sys/IBM300SY_4BSD_Os i386


>Description:

>From my portupgrade log:

[...]
--->  Reinstallation of net-mgmt/mbrowse started at: Mon, 16 Aug 2004 10:48:42 -0500
--->  Reinstalling 'mbrowse-0.3.1_1' (net-mgmt/mbrowse)
--->  Build of net-mgmt/mbrowse started at: Mon, 16 Aug 2004 10:48:42 -0500
--->  Building '/usr/ports/net-mgmt/mbrowse'
===>  Building for mbrowse-0.3.1_1
make  all-recursive
Making all in src
if cc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include/gtk12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/X11R6/include -I/usr/local/include -DHAVE_NETSNMP   -DINET6 -O -pipe -march=pentium2 -pipe -Os -march=pentium2 -Dfreebsd5 -DAPPLLIB_EXP=/usr/local/lib/perl5/5.8.5/BSDPAN -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -I/usr/local/include -I/usr/local/lib/perl5/5.8.5/mach/CORE -I. -I/usr/local/include  -O -pipe -march=pentium2 -pipe -Os -march=pentium2 -Wall -MT snmpstuff.o -MD -MP -MF ".deps/snmpstuff.Tpo"  -c -o snmpstuff.o `test -f 'snmpstuff.c' || echo './'`snmpstuff.c;  then mv ".deps/snmpstuff.Tpo" ".deps/snmpstuff.Po";  else rm -f ".deps/snmpstuff.Tpo"; exit 1;  fi
In file included from callbacks.h:6,
                 from snmpstuff.c:25:
/usr/local/include/net-snmp/net-snmp-config.h:871:1: warning: "PACKAGE_BUGREPORT" redefined
In file included from snmpstuff.c:17:
../config.h:30:1: warning: this is the location of the previous definition
In file included from callbacks.h:6,
                 from snmpstuff.c:25:
/usr/local/include/net-snmp/net-snmp-config.h:874:1: warning: "PACKAGE_NAME" redefined
In file included from snmpstuff.c:17:
../config.h:33:1: warning: this is the location of the previous definition
In file included from callbacks.h:6,
                 from snmpstuff.c:25:
/usr/local/include/net-snmp/net-snmp-config.h:877:1: warning: "PACKAGE_STRING" redefined
In file included from snmpstuff.c:17:
../config.h:36:1: warning: this is the location of the previous definition
In file included from callbacks.h:6,
                 from snmpstuff.c:25:
/usr/local/include/net-snmp/net-snmp-config.h:880:1: warning: "PACKAGE_TARNAME" redefined
In file included from snmpstuff.c:17:
../config.h:39:1: warning: this is the location of the previous definition
In file included from callbacks.h:6,
                 from snmpstuff.c:25:
/usr/local/include/net-snmp/net-snmp-config.h:883:1: warning: "PACKAGE_VERSION" redefined
In file included from snmpstuff.c:17:
../config.h:42:1: warning: this is the location of the previous definition
snmpstuff.c: In function `snmpset':
snmpstuff.c:363: error: label at end of compound statement
*** Error code 1

Stop in /src/ports/net-mgmt/mbrowse/work/mbrowse-0.3.1/src.
*** Error code 1

Stop in /src/ports/net-mgmt/mbrowse/work/mbrowse-0.3.1.
*** Error code 1

Stop in /src/ports/net-mgmt/mbrowse/work/mbrowse-0.3.1.
*** Error code 1

Stop in /src/ports/net-mgmt/mbrowse.
** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade40020.7 make
** Fix the problem and try again.
--->  Build of net-mgmt/mbrowse ended at: Mon, 16 Aug 2004 10:48:46 -0500 (consumed 00:00:04)
--->  Reinstallation of net-mgmt/mbrowse ended at: Mon, 16 Aug 2004 10:48:46 -0500 (consumed 00:00:04)
[...]


>How-To-Repeat:

Try building net-mgmt/mbrowse with -Current's system gcc342.


>Fix:

The new gcc is tightening-up the language specs. 
The 'default:' label needs a 'break;' statement. 
Here's a patch to add to the files/ subdir (I
named this 'patch-src:snmpstuff.c'):

===cut-here===
--- src/snmpstuff.c_orig	Fri Jun 21 06:45:18 2002
+++ src/snmpstuff.c	Tue Aug 17 10:59:05 2004
@@ -360,6 +360,7 @@ void snmpset(char *host,char *object,cha
       case TYPE_NETADDR:
       case TYPE_OTHER:
       default:
+	break;
     }
   }
   if (type == 0) {
===cut-here===


At least it compiles now. 
No testing yet on how well it runs.  ;)

There haven't been any updates for this
project in quite a long time. 
Who should send this patch up-stream,
or should we even bother?



  --  thx, Paul Seniura
           System Specialist
           State of Okla. D.O.T.

>Release-Note:
>Audit-Trail:
>Unformatted: