ports/58370: [PATCH] recently change in x11-fm/gnome-commander makes it crash

[Jens Rehsack]

>Number:         58370
>Category:       ports
>Synopsis:       [PATCH] recently change in x11-fm/gnome-commander makes it crash
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 22 02:20:11 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Jens Rehsack
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
LiWing IT-Services
>Environment:
System: FreeBSD statler 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Tue Oct 21 09:54:47 GMT 2003 root at statler:/usr/obj/usr/src/sys/STATLER i386


	
>Description:
	The change in x11-fm/gnome-commander made to solve a problem with
	package building found by Kris on bento makes the application crash
	with:
WARNING: Couldn't load installed file type pixmap, trying to load from source-dir
WARNING: Trying to load ../pixmaps/gnome_cmd_arrow_up.xpm instead
...
Gtk-CRITICAL **: file gtkpixmap.c: line 97 (gtk_pixmap_new): assertion `val != NULL' failed.
...
** CRITICAL **: file utils.c: line 866 (create_styled_pixmap_button): assertion `text || pm' failed.
GLib-CRITICAL **: file gdataset.c: line 359 (g_datalist_id_set_data_full): assertion `destroy_func == NULL' failed.
Gtk-WARNING **: invalid cast from (NULL) pointer to `GtkObject'
	However, using automake/autoconf seems to work, even when I build
	packages locally. If I would know a little more about the problem
	on bento I can perhaps create a patch that satisfy both, bento and
	the users (later) :-)

	I've seen the port has no maintainter, so I would offer me.

>How-To-Repeat:
	
>Fix:

	

--- patch-automake begins here ---
Index: x11-fm/gnome-commander/Makefile
===================================================================
diff -u x11-fm/gnome-commander/Makefile.orig x11-fm/gnome-commander/Makefile
--- x11-fm/gnome-commander/Makefile.orig	Thu Oct 16 19:18:24 2003
+++ x11-fm/gnome-commander/Makefile	Wed Oct 22 09:07:42 2003
@@ -10,7 +10,7 @@
 CATEGORIES=	x11-fm gnome
 MASTER_SITES=	http://savannah.nongnu.org/download/gcmd/gcmd.pkg/${PORTVERSION}/
 
-MAINTAINER=	ports at freebsd.org
+MAINTAINER=	rehsack at liwing.de
 COMMENT=	File manager for Gnome
 
 .if defined(WITH_FAM)
@@ -24,6 +24,10 @@
 USE_BZIP2=	yes
 USE_GNOME=	gnomeprefix gnomehack gnometarget gnomevfs gnomelibs gdkpixbuf
 GNU_CONFIGURE=	yes
+USE_AUTOCONF=	yes
+WANT_AUTOCONF_VER=	253
+USE_AUTOMAKE=	yes
+WANT_AUTOMAKE_VER=	14
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include -I${X11BASE}/include" \
 		LIBS="-L${LOCALBASE}/lib -L${X11BASE}/lib -lintl"
 
--- patch-automake ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: