ports/58072: Broken port: www/galeon, undefined reference

[Esa Karkkainen]

>Number:         58072
>Category:       ports
>Synopsis:       Broken port: www/galeon, undefined reference
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 15 08:00:33 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Esa Karkkainen
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
Is in state of disintegration
>Environment:

System: FreeBSD 5.1-CURRENT #14: Fri Oct 3 20:12:21 EEST 2003
Same applies to 4-STABLE branch

Ports cvsupped Tue Oct 14 17:39 EEST 2003

>Description:

Same bug which is corrected in www/galeon2/files/patch-mozilla_GlobalHistory.cpp

cd /usr/ports/www/galeon && make all

[snip]

../src/mozilla/libmozilla-interaction.a(GlobalHistory.o)(.gnu.linkonce.r._ZTV13GlobalHistory+0x3c): undefined reference to `GlobalHistory::SetLastPageVisited(char const*)'
../src/mozilla/libmozilla-interaction.a(GlobalHistory.o)(.gnu.linkonce.r._ZTV13GlobalHistory+0x74): undefined reference to `non-virtual thunk to GlobalHistory::SetLastPageVisited(char const*)'
gmake[4]: *** [galeon-bin] Error 1
gmake[4]: Leaving directory `/usr/ports/www/galeon/work/galeon-1.2.12/src'
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory `/usr/ports/www/galeon/work/galeon-1.2.12/src'
gmake[2]: *** [all] Error 2
gmake[2]: Leaving directory `/usr/ports/www/galeon/work/galeon-1.2.12/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/www/galeon/work/galeon-1.2.12'
gmake: *** [all] Error 2
*** Error code 2

Stop in /usr/ports/www/galeon.

>How-To-Repeat:

cd /usr/ports/www/galeon && make all

>Fix:

diff -ruN ports/www/galeon.orig/files/patch-mozilla_GlobalHistory.cpp ports/www/galeon/files/patch-mozilla_GlobalHistory.cpp
--- ports/www/galeon.orig/files/patch-mozilla_GlobalHistory.cpp	Thu Jan  1 02:00:00 1970
+++ ports/www/galeon/files/patch-mozilla_GlobalHistory.cpp	Tue Oct 14 17:45:02 2003
@@ -0,0 +1,11 @@
+--- src/mozilla/GlobalHistory.cpp.orig	Tue Oct 14 17:43:42 2003
++++ src/mozilla/GlobalHistory.cpp	Tue Oct 14 17:44:08 2003
+@@ -108,7 +108,7 @@
+ 	return NS_OK;
+ }
+ 
+-#if MOZILLA_SNAPSHOT > 9
++#if MOZILLA_SNAPSHOT >= 9
+ NS_IMETHODIMP GlobalHistory::SetLastPageVisited(const char * aLastPageVisited)
+ {
+ 	mLastPageVisited.Assign(aLastPageVisited);
>Release-Note:
>Audit-Trail:
>Unformatted: