ports/57531: Fix port: net/nicotine Makefile missing/broken RUN_DEPENDS

Peter Pentchev roam at ringlet.net
Fri Oct 3 14:30:23 UTC 2003


The following reply was made to PR ports/57531; it has been noted by GNATS.

From: Peter Pentchev <roam at ringlet.net>
To: Jens Rehsack <rehsack at liwing.de>
Cc: Stefan Walter <sw at gegenunendlich.de>, bug-followup at FreeBSD.org
Subject: Re: ports/57531: Fix port: net/nicotine Makefile missing/broken RUN_DEPENDS
Date: Fri, 3 Oct 2003 17:29:38 +0300

 --n2Pv11Ogg/Ox8ay5
 Content-Type: text/plain; charset=windows-1251
 Content-Disposition: inline
 
 On Fri, Oct 03, 2003 at 02:20:15PM +0000, Jens Rehsack wrote:
 > Stefan Walter wrote:
 > >Jens Rehsack, 03.10.03, 15:54h CEST:
 > >
 > >
 > >>>--- nicotine-run_depends.patch begins here ---
 > >>>--- Makefile~	Tue Sep 30 20:00:14 2003
 > >>>+++ Makefile	Fri Oct  3 15:23:42 2003
 > >>>@@ -22,7 +22,7 @@
 > >>>.include <bsd.port.pre.mk>
 > >>>
 > >>>.if exists(${PYTHON_SITELIBDIR}/ogg/vorbis.so) || defined(WITH_VORBIS)
 > >>>-RUN_DEPENDS= 
 > >>>${PYTHON_SITELIBDIR}/ogg/vorbis.so:${PORTSDIR}/audio/py-vorbis
 > >>>+RUN_DEPENDS+= 
 > >>>${PYTHON_SITELIBDIR}/ogg/vorbis.so:${PORTSDIR}/audio/py-vorbis
 > >>>.else
 > >>>pre-everything::
 > >>>	@${ECHO_MSG} ""
 > >>>--- nicotine-run_depends.patch ends here ---
 > >>
 > >>Could LIB_DEPENDS used here?
 > >
 > >
 > >Yes - thinking about it, it would probably be the more correct
 > >way...should we change that again?
 > 
 > I think you should do it. Because I don't use the port and have some
 > other things to do at the moment, this would be faster.
 
 Stefan, could you test the attached patch?  If it works for you,
 I can commit it in a minute.
 
 G'luck,
 Peter
 
 -- 
 Peter Pentchev	roam at ringlet.net    roam at sbnd.net    roam at FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 This sentence contradicts itself - or rather - well, no, actually it doesn't!
 
 --n2Pv11Ogg/Ox8ay5
 Content-Type: text/plain; charset=windows-1251
 Content-Disposition: attachment; filename="nicotine.patch"
 
 Index: ports/net/nicotine/Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/net/nicotine/Makefile,v
 retrieving revision 1.7
 diff -u -r1.7 Makefile
 --- ports/net/nicotine/Makefile	3 Oct 2003 13:58:42 -0000	1.7
 +++ ports/net/nicotine/Makefile	3 Oct 2003 14:28:20 -0000
 @@ -23,7 +23,7 @@
  .include <bsd.port.pre.mk>
  
  .if exists(${PYTHON_SITELIBDIR}/ogg/vorbis.so) || defined(WITH_VORBIS)
 -RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/ogg/vorbis.so:${PORTSDIR}/audio/py-vorbis
 +LIB_DEPENDS=	${PYTHON_SITELIBDIR}/ogg/vorbis.so:${PORTSDIR}/audio/py-vorbis
  .else
  pre-everything::
  	@${ECHO_MSG} ""
 
 --n2Pv11Ogg/Ox8ay5--



More information about the freebsd-ports-bugs mailing list