ports/59784: Add WITH_FRIBIDI option to x11/mlterm

[Samy Al Bahra]

>Number:         59784
>Category:       ports
>Synopsis:       Add WITH_FRIBIDI option to x11/mlterm
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 28 21:10:20 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Samy Al Bahra
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
Kerneled 
>Environment:


System: FreeBSD beastie.freebsd.local 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Wed Aug 20 18:35:24 AST 2003     samy at beastie.freebsd.local:/usr/src/sys/i386/compile/KERNELED i386


>Description:


The x11/mlterm port currently has no way
for the user to enable BiDi support without
tampering with CONFIGURE_ARGS directly.
mlterm is a very popular terminal for users
in the Middle East since it provides decent
support for Arabic and Arabic-like languages,
WHEN Fribidi support is enabled.


>How-To-Repeat:





>Fix:


The following patch adds a WITH_FRIBIDI
option though I do recommend to moving
this to WITHOUT_FRIBIDI and enabling
Fribidi by default.

--- mlterm.patch begins here ---
--- mlterm/Makefile	Fri Nov 28 19:22:01 2003
+++ /home/samy/tmp/mlterm/Makefile	Fri Nov 28 19:33:24 2003
@@ -19,6 +19,12 @@
 USE_LIBTOOL=	yes
 USE_REINPLACE=	yes
 CONFIGURE_ARGS=	--with-imagelib=gdk-pixbuf1 --enable-utmp
+
+.if defined(WITH_FRIBIDI)
+CONFIGURE_ARGS=	--enable-fribidi
+LIB_DEPENDS=	fribidi.0:${PORTSDIR}/converters/fribidi
+.endif
+
 INSTALLS_SHLIB=	yes
 
 MAN1=	mlterm.1 mlclient.1
@@ -30,6 +36,14 @@
 .else
 CONFIGURE_ARGS+=	--enable-anti-alias
 LIB_DEPENDS=	Xft.2:${PORTSDIR}/x11-fonts/Xft
+.endif
+
+pre-everything::
+.if !defined(WITH_FRIBIDI)
+	@${ECHO_MSG}
+	@${ECHO_MSG} "You may enable BiDi support by using the"
+	@${ECHO_MSG} "WITH_FRIBIDI option."
+	@${ECHO_MSG}
 .endif
 
 post-configure:
--- mlterm.patch ends here ---



>Release-Note:
>Audit-Trail:
>Unformatted: