ports/51771: sysutils/bubblemon overflow

[Jim Geovedi]

>Number:         51771
>Category:       ports
>Synopsis:       sysutils/bubblemon overflow
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 04 16:50:14 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Jim Geovedi
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
Liquid Magnesium Networks
>Environment:
System: FreeBSD toxic.magnesium.net 4.6-STABLE FreeBSD 4.6-STABLE #5: Thu Aug 1 09:24:17 PDT 2002 unfurl at toxic.magnesium.net:/users/world/obj/users/world/src/sys/TOXIC i386


	
>Description:
	Overflow in bubblemon's code. Version affected =< 1.2.9.
	
	
>How-To-Repeat:
	
>Fix:

	

--- patch-src_bubblemon_c begins here ---
--- src/bubblemon.c.orig	Mon Jul 22 10:19:32 2002
+++ src/bubblemon.c	Sun May  4 16:31:56 2003
@@ -170,7 +170,7 @@
 
   if (sysload.nCpus == 1)
     {
-      snprintf(loadstring, 45,
+      snprintf(loadstring, sizeof loadstring,
                _("\nCPU load: %d%%"),
                bubblemon_getCpuLoadPercentage(0));
       strcat(tooltipstring, loadstring);
@@ -181,7 +181,7 @@
            cpu_number < sysload.nCpus;
            cpu_number++)
         {
-          snprintf(loadstring, 45,
+          snprintf(loadstring, sizeof loadstring,
                    _("\nCPU #%d load: %d%%"),
                    cpu_number,
                    bubblemon_getCpuLoadPercentage(cpu_number));
--- patch-src_bubblemon_c ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: