ports/52973: ports/www/apache2 install failure

[Morten Rodal]

>Number:         52973
>Category:       ports
>Synopsis:       ports/www/apache2 install failure
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 05 12:10:07 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Morten Rodal
>Release:        FreeBSD 5.1-BETA i386
>Organization:
>Environment:
System: FreeBSD atlantis.rodal.no 5.1-BETA FreeBSD 5.1-BETA #30: Sat May 31 16:12:18 CEST 2003 root at atlantis.rodal.no:/usr/obj/usr/src/sys/atlantis i386

NOTE: also applies to FreeBSD 4.8-RELEASE.

>Description:

The ``make install'' fails with:

  # make install
  ===>  Installing for apache-2.0.45
  ===>   apache-2.0.45 depends on shared library: expat.4 - found
  PKG_PREFIX=/usr/local /bin/sh pkg-install apache-2.0.45 PRE-INSTALL
  pkg-install: Can't open pkg-install: No such file or directory
  *** Error code 2

  Stop in /usr/ports/www/apache2.
  #

Adding a ``pwd'' just after the ``pre-install:'' line in the Makefile
shows that the script is being run from the wrong directory.


NOTE: This is still not fixed in 2.0.46!
NOTE: This also applies to a few other ports that also do not use the
      ${PKGINSTALL} variable instead of referencing pkg-install.

>How-To-Repeat:

Set WRKDIRPREFIX in /etc/make.conf and try to ``make install'' on
www/apache2 port.  I used WRKDIRPREFIX="/usr/obj" on my machines.
I do not know if the WRKDIRPREFIX is the root of the cause, but that
is the only thing seperating my machines from a standard FreeBSD
environment.

>Fix:

Change the Makefile to use ${PKGINSTALL} instead of ``pkg-install.''
A suggestive patch is included below.


--- Makefile.old	Wed Apr 16 23:33:58 2003
+++ Makefile	Sat May 31 20:04:26 2003
@@ -134,7 +134,7 @@
 	@${RM} -f ${WRKSRC}/docs/manual/index.html.ko.euc-kr
 
 pre-install:
-	PKG_PREFIX=${PREFIX} ${SH} pkg-install ${PKGNAME} PRE-INSTALL
+	@${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
 
 post-install:
 	@if [ ! -f ${PREFIX}/etc/rc.d/apache2.sh ]; then \

>Release-Note:
>Audit-Trail:
>Unformatted: