ports/54805: makeself port problems

[Andriy I Pylypenko]

>Number:         54805
>Category:       ports
>Synopsis:       makeself port problems
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 24 04:30:16 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Andriy I Pylypenko
>Release:        FreeBSD 4.8-RELEASE i386
>Organization:
Oranta
>Environment:
System: FreeBSD it-pilai.kv.ornt 4.8-RELEASE FreeBSD 4.8-RELEASE #3: Wed Jul 16 13:14:50 EEST 2003 bamby at it-pilai.kv.ornt:/usr/src/sys/compile/BAMBY i386

>Description:
There are two problems with makeself port. 

1. Starting from version 2.x makeself binary consists of two scripts - makeself.sh and makeself-header.sh. The port was updated recently, but file makeself-header.sh was not added to port.

2. The makeself script is not compatible with FreeBSD's /bin/sh. It produces broken archives when runs under /bin/sh. Changing interpreter to bash resolves this problem.

>How-To-Repeat:
Problem 1. Install makeself from the ports collection and try to run it. It will fail and will report that the makeself-header.sh file is missing.

Problem 2. Copy makeself-header.sh to /usr/local/bin/ to avoid first problem, create the self-extracting archive with the makeself then try to run that archive. Self-extractor will fail and will complain about checksum error.

>Fix:
The following patch resolves both of these problems.



Index: makeself/Makefile
diff -c makeself/Makefile:1.1.1.1 makeself/Makefile:1.2
*** makeself/Makefile:1.1.1.1	Thu Jul 24 11:38:53 2003
--- makeself/Makefile	Thu Jul 24 11:46:57 2003
***************
*** 20,27 ****
--- 20,30 ----
  
  NO_BUILD=	yes
  
+ RUN_DEPENDS=	/usr/local/bin/bash:/usr/ports/shells/bash2
+ 
  do-install:
  	${INSTALL_SCRIPT} ${WRKSRC}/makeself.sh ${PREFIX}/bin/makeself
+ 	${INSTALL_SCRIPT} ${WRKSRC}/makeself-header.sh ${PREFIX}/bin/makeself-header.sh
  .if !defined(NOPORTDOCS)                                                       
  	@${MKDIR} ${DOCSDIR}                                                    
  	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}                             
Index: makeself/pkg-plist
diff -c makeself/pkg-plist:1.1.1.1 makeself/pkg-plist:1.3
*** makeself/pkg-plist:1.1.1.1	Thu Jul 24 11:38:53 2003
--- makeself/pkg-plist	Thu Jul 24 11:50:40 2003
***************
*** 1,3 ****
--- 1,4 ----
  bin/makeself
+ bin/makeself-header.sh
  %%PORTDOCS%%%%DOCSDIR%%/README                                          
  %%PORTDOCS%%@dirrm %%DOCSDIR%%
Index: makeself/files/patch-makeself.sh
diff -c /dev/null makeself/files/patch-makeself.sh:1.1
*** /dev/null	Thu Jul 24 11:53:01 2003
--- makeself/files/patch-makeself.sh	Thu Jul 24 11:47:01 2003
***************
*** 0 ****
--- 1,13 ----
+ *** makeself.sh.orig	Thu Jul 24 11:42:36 2003
+ --- makeself.sh	Thu Jul 24 11:42:45 2003
+ ***************
+ *** 1,4 ****
+ ! #!/bin/sh
+   #
+   # Makeself version 2.1.x
+   #  by Stephane Peter <megastep at megastep.org>
+ --- 1,4 ----
+ ! #!/usr/local/bin/bash
+   #
+   # Makeself version 2.1.x
+   #  by Stephane Peter <megastep at megastep.org>
>Release-Note:
>Audit-Trail:
>Unformatted: