ports/51139: [patch] ports/palm/coldsync dumps core

[Helge Oldach]

>Number:         51139
>Category:       ports
>Synopsis:       [patch] ports/palm/coldsync dumps core
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 18 14:40:09 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Helge Oldach
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
>Environment:
System: FreeBSD sep.oldach.net 4.8-STABLE FreeBSD 4.8-STABLE #0: Wed Apr 9 19:47:13 CEST 2003 toor at sep:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:

coldsync 2.2.5 dumps core because of an uninitialized pointer if no PDA
clause is defined in the configuration file.

bug raised with vendor as well.

>How-To-Repeat:
	
>Fix:

--- src/coldsync.c.ORIG	Fri Apr 18 22:59:58 2003
+++ src/coldsync.c	Fri Apr 18 23:10:57 2003
@@ -622,7 +622,7 @@
 
 	time(&now);
 	Verbose(1, _("Sync for %s at %s"),
-		(pda->name == NULL ? "unnamed PDA" : pda->name),
+		(pda == NULL || pda->name == NULL ? "unnamed PDA" : pda->name),
 		ctime(&now));
 
 	/* See if the userid matches. */


>Release-Note:
>Audit-Trail:
>Unformatted: